feat: add custom ingress label values #4063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
hisImminence
requested review from
aabouzaid
and removed request for
jessesimpson36
jessesimpson36
previously requested changes
Sep 3, 2025
Contributor
jessesimpson36
left a comment
jessesimpson36
left a comment
There was a problem hiding this comment.
Implementation and tests look fine, but one minor point on including the labels within camundaPlatform.labels helper function rather than in the template.
Member
|
I believe that we need this feature for all versions. |
Member
I've discussed with @hisImminence, and we will start with 8.8 and later add support for other versions. |
aabouzaid
reviewed
Sep 3, 2025
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4063-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
aabouzaid
force-pushed
the
2679-custom-ingress-labels
branch
from
d1b27dc to
9628bf6
Compare
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4063-intg-8-8-gke-eske-upgrade
github-actions
bot
added
the
version:13.0.0-alpha8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
product-hub #2679
What's in this PR?
Adds a new labels value to each ingress in values.yaml
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: