fix: revert webmodeler externaldb change #4071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
version/8.8
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
hisImminence
requested review from
aabouzaid
and removed request for
hamza-m-masood
| .Values.webModeler.restapi.externalDatabase.host | ||
| (toString (.Values.webModeler.restapi.externalDatabase.port)) | ||
| (.Values.webModeler.restapi.externalDatabase.database) | ||
| -}} |
Contributor
There was a problem hiding this comment.
This looks like we're dropping support for externalDatabase.host, externalDatabase.port, and so on.
We normally do not just drop support for options like this. we typically talk with product management about a timeframe schedule notifying users of the setting to be removed, and a schedule for removal.
Member
Author
There was a problem hiding this comment.
I forgot it was added to 8.7, too. I think it's simpler to just remove the deprecation notice for now and make no functional changes
jessesimpson36
requested changes
Sep 3, 2025
Contributor
jessesimpson36
left a comment
jessesimpson36
left a comment
There was a problem hiding this comment.
I think this needs to be a conversation with product-management.
This reverts commit 3857e26.
…munda/camunda-platform-helm into 4046-webmodeler-db-url-revert
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es-upgrade
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
jessesimpson36
approved these changes
Sep 3, 2025
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-8-gke-eske
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
distro-ci-manage-gh-envs
bot
temporarily deployed
to
gke-4071-intg-8-7-gke-es-upgrade
distro-ci-manage-gh-envs
bot
requested a deployment
to
gke-4071-intg-8-8-gke-eske-upgrade
This was referenced Sep 4, 2025
github-actions
bot
added
version:12.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Closes: #4046
What's in this PR?
Revert prior webmodeler DB change, favoring JDBC URL only configuration
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: