Skip to content

Conversation

@hisImminence
Copy link
Contributor

Which problem does the PR fix?

follow up of #4137

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hisImminence hisImminence self-assigned this Sep 11, 2025
@hisImminence hisImminence marked this pull request as ready for review September 11, 2025 18:52
@hisImminence hisImminence requested a review from a team as a code owner September 11, 2025 18:52
@github-actions github-actions bot added the version/8.8 Camunda applications/cycle version label Sep 11, 2025
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4147-intg-8-8-gke-eske September 11, 2025 18:54 Destroyed
@hamza-m-masood hamza-m-masood self-requested a review September 11, 2025 19:03
Copy link
Contributor

@hamza-m-masood hamza-m-masood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hisImminence I don't think this is correct. This global section changes the orchestration cluster as well.
Example:

- {{ .Values.global.identity.auth.orchestration.audience | quote }}

@hisImminence hisImminence force-pushed the fix-identity-comment-in-8.8-values.yaml branch from 5ff68dc to 2b376eb Compare September 11, 2025 20:39
@hisImminence
Copy link
Contributor Author

@hisImminence I don't think this is correct. This global section changes the orchestration cluster as well. Example:

- {{ .Values.global.identity.auth.orchestration.audience | quote }}

Okay! Lets see if this makes more sense. Else happy to close this PR.

@jessesimpson36
Copy link
Contributor

Needs ported to 8.9 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-latest version/8.8 Camunda applications/cycle version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants