Skip to content

Conversation

@EuroLew
Copy link
Contributor

@EuroLew EuroLew commented Sep 11, 2025

Which problem does the PR fix?

There is an issue where if one ES pod goes down due to replicas = 0 it will block the main application, to stop secondary storage blocking like this and make Camudna more HA replicas should be 1 for unified indices. camunda/camunda#35080

This is a breaking change for the upgrade from 8.7->8.8, I want this to be in the helm chart for 8.8 upgrade is the way I'm doing it correct?

This is also paired with a documentation PR that tells the user about the need for more space and how to rollback. camunda/camunda-docs#6664. The rollback has been tested and works in the gke-4150-intg-8-8-gke-eske namespace

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • [] Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added version/8.8 Camunda applications/cycle version component/orchestration labels Sep 11, 2025
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4150-intg-8-8-gke-eske September 11, 2025 21:38 Destroyed
@EuroLew EuroLew force-pushed the el-default-replicas-to-1 branch 2 times, most recently from 574911a to 65c50ad Compare September 11, 2025 21:44
@EuroLew EuroLew changed the title feat: set default replicas for 8.8 camunda to 1 for ES/OS (breaking c… feat: set default replicas for 8.8 camunda to 1 for ES/OS - breaking change Sep 11, 2025
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4150-intg-8-8-gke-eske September 11, 2025 21:46 Destroyed
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4150-intg-8-8-gke-eske September 11, 2025 21:49 Destroyed
@EuroLew EuroLew marked this pull request as ready for review September 12, 2025 07:46
@EuroLew EuroLew requested a review from a team as a code owner September 12, 2025 07:46
@EuroLew EuroLew requested a review from bkenez September 12, 2025 07:46
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4150-intg-8-8-gke-eske September 12, 2025 07:49 Destroyed
@bkenez
Copy link
Member

bkenez commented Sep 16, 2025

Looks good, just some wording/naming change suggestions 👍

@EuroLew EuroLew force-pushed the el-default-replicas-to-1 branch from 31436b6 to 6de8534 Compare September 16, 2025 11:53
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4150-intg-8-8-gke-eske September 16, 2025 11:56 Destroyed
@EuroLew EuroLew requested a review from bkenez September 16, 2025 11:59
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4150-intg-8-8-gke-eske September 16, 2025 11:59 Destroyed
@hisImminence hisImminence requested review from aabouzaid and removed request for bkenez September 16, 2025 12:20
@hisImminence
Copy link
Contributor

@aabouzaid, pinging you for the final review as marked as breaking change!

@aabouzaid aabouzaid added kind/breaking-change A change that potentially causes other components to fail and needs a migration steps/guide kind/refactor labels Sep 16, 2025
@aabouzaid aabouzaid force-pushed the el-default-replicas-to-1 branch from 30808df to 46be2a4 Compare September 16, 2025 23:25
@distro-ci-manage-gh-envs distro-ci-manage-gh-envs bot temporarily deployed to gke-4150-intg-8-8-gke-eske September 16, 2025 23:28 Destroyed
@aabouzaid aabouzaid changed the title feat: set default replicas for 8.8 camunda to 1 for ES/OS - breaking change refactor: set default replicas to 1 for secondary storage Sep 16, 2025
@aabouzaid aabouzaid merged commit 5c11abe into main Sep 16, 2025
7 checks passed
@aabouzaid aabouzaid deleted the el-default-replicas-to-1 branch September 16, 2025 23:38
@aabouzaid aabouzaid added the size/xs 1-2 days label Sep 16, 2025
@aabouzaid
Copy link
Member

@EuroLew I've ported the change in the unified config for the Camunda Exporter, but number-of-replicas is still not supported in the Secondary Storage config.

Please confirm that having it for Camunda Exporter only is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/orchestration kind/breaking-change A change that potentially causes other components to fail and needs a migration steps/guide kind/refactor size/xs 1-2 days version/8.8 Camunda applications/cycle version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants