fix: remap replicas key from legacy to new keys

[bkenez]

Which problem does the PR fix?

Closes: #4184

What's in this PR?

Remaps .Values.orchestration.index.replicas to use the new unified configuration fields instead of the legacy ones.\

Might need to wait with merging until we are sure the underlying app has gotten the update.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

• In the repo's root dir, run make go.update-golden-only.
• There is no other open pull request for the same update/change.
• Tests for charts are added (if needed).
• In-repo documentation are updated (if needed).

After opening the PR:

• Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
• Did all checks/tests pass in the PR?

[hisImminence]

QQ @bkenez , how can the CI be green if our tests run against a app version where the change is not yet implemented? Dont we test this case configuration setting?

[bkenez]

QQ @bkenez , how can the CI be green if our tests run against a app version where the change is not yet implemented? Dont we test this case configuration setting?

Either that, or the new settings are already implemented on an earlier version just undocumented 🤔

[jessesimpson36]

Tests are running against values-digest (aka snapshot), is the feature not yet implemented in snapshot?

testing locally first

[jessesimpson36]

I deployed against this branch against values-digest, and setting the replica count to 2 does not show in /orchestration/actuator/configprops a value of 2. it shows 1 but only for the legacy option.

[jessesimpson36]

Wait for snapshot to receive feature