chore: fix pre-existing gofmt drift across chart test suites and scripts#6311
Open
eamonnmoloney wants to merge 1 commit into
Open
chore: fix pre-existing gofmt drift across chart test suites and scripts#6311eamonnmoloney wants to merge 1 commit into
eamonnmoloney wants to merge 1 commit into
Conversation
github-actions
Bot
added
version/8.3
Running gofmt over the repo surfaces ~48 Go files (chart unit tests across 8.3-8.10 and the scripts/ tooling) with pre-existing formatting drift — mostly trailing whitespace and alignment. No logic changes; gofmt-only. Brings the tree to a clean 'gofmt -l' so the formatting gate is meaningful and future diffs aren't polluted by incidental reformatting. Regenerated against current main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
eamonnmoloney
force-pushed
the
chore-gofmt-drift
branch
from
71536b0 to
397ab66
Compare
eamonnmoloney
requested review from
Ian-wang-liyang and
Copilot
and removed request for
a team and
Copilot
6 tasks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
The repo has accumulated pre-existing
gofmtdrift:gofmt -l charts/ scripts/lists 52 Go files (chart unit tests across 8.3–8.10 and thescripts/tooling) that aren't gofmt-clean — mostly trailing whitespace and alignment. This pollutes unrelated diffs (anymake go.fmtrun sweeps them up) and makes the formatting gate noisy.What's in this PR?
gofmt -w charts/ scripts/— formatting only, no logic changes. The tree is now clean togofmt -l.Spot example (
charts/camunda-platform-8.5/test/unit/console/types.go): a struct field had a trailing tab that gofmt strips.scripts/deploy-camundaand the other Go modules still build.Pure mechanical cleanup, intentionally separate from any feature PR so the formatting churn doesn't bury substantive review.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: