Skip to content

test: add registry-camunda-cloud pull secret to camunda component integration values#6449

Merged
eamonnmoloney merged 2 commits into
mainfrom
fix/connectors-integration-pull-secret
Jun 26, 2026
Merged

test: add registry-camunda-cloud pull secret to camunda component integration values#6449
eamonnmoloney merged 2 commits into
mainfrom
fix/connectors-integration-pull-secret

Conversation

@eamonnmoloney

@eamonnmoloney eamonnmoloney commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Which problem does the PR fix?

Camunda-image pods in chart-full-setup integration/nightly deploys fail with ImagePullBackOff whenever a component image is overridden to a registry.camunda.cloud build (e.g. registry.camunda.cloud/team-connectors/connectors-bundle:8.8.14-stable-8.8-run<id>). The kubelet reports pull access denied … no basic auth credentials.

Root cause: camundaPlatform.subChartImagePullSecrets (templates/common/_helpers.tpl) is an else if, not a merge — a component-level image.pullSecrets fully replaces global.image.pullSecrets. The global camunda default is only index-docker-io, so any component whose image is overridden to the Camunda registry but lacks an explicit registry-camunda-cloud entry authenticates anonymously and fails to pull. First observed on connectors (namespace camunda-id-connectors-int-…): in the same pod set, web-modeler-restapi got both secrets (inline in base.yaml) while connectors got only the global one. The same gap exists for every other camunda component that has no inline image.pullSecrets.

What's in this PR?

Mirror the webModeler/console pattern for the remaining camunda components in each version's chart-full-setup/values/base.yaml, adding both index-docker-io and registry-camunda-cloud to image.pullSecrets:

  • 8.8 – 8.10: connectors, identity, optimize, orchestration
  • 8.7 (pre-unified split): connectors, identity, operate, optimize, tasklist, zeebe, zeebeGateway

(index-docker-io is repeated because component-level pull secrets replace rather than merge with global, so the Docker-Hub default pull must stay covered. A global fix is not viable uniformly — 8.9/8.10 have no global.image.pullSecrets key at all.)

Values-file-only change — no chart templates touched, so no golden snapshots are affected.

Verified: helm lint passes for all four versions, and helm template … -f base.yaml now renders every camunda workload (identity, optimize, connectors, console, web-modeler-*, orchestration/zeebe, plus 8.7 operate/tasklist/zeebe-gateway) with both index-docker-io and registry-camunda-cloud.

Checklist

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)?

…n values

The connectors component in the chart-full-setup integration scenario only
resolved imagePullSecrets [index-docker-io] (the global fallback), so deploys
that override connectors.image to a registry.camunda.cloud build hit the
registry anonymously and failed with ImagePullBackOff
("no basic auth credentials").

camundaPlatform.subChartImagePullSecrets is else-if, not a merge: a
component-level image.pullSecrets fully replaces global.image.pullSecrets.
webModeler already carries both secrets inline in base.yaml; connectors was
missed. Mirror the webModeler pattern across 8.7-8.10 so connectors gets both
index-docker-io and registry-camunda-cloud.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added version/8.7 Camunda applications/cycle version version/8.8 Camunda applications/cycle version version/8.9 Camunda applications/cycle version version/8.10 Camunda applications/cycle version labels Jun 25, 2026
@eamonnmoloney eamonnmoloney marked this pull request as ready for review June 25, 2026 10:26
@eamonnmoloney eamonnmoloney requested a review from a team as a code owner June 25, 2026 10:26
@eamonnmoloney eamonnmoloney requested review from bkenez and Copilot and removed request for a team June 25, 2026 10:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the chart-full-setup integration scenario base values so the Connectors pod template renders with both Docker Hub (index-docker-io) and Camunda Cloud registry (registry-camunda-cloud) imagePullSecrets when Connectors images are overridden to registry.camunda.cloud.

Changes:

  • Add connectors.image.pullSecrets entries for index-docker-io and registry-camunda-cloud in the chart-full-setup base values.
  • Apply the same change consistently across chart versions 8.7, 8.8, 8.9, and 8.10.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
charts/camunda-platform-8.7/test/integration/scenarios/chart-full-setup/values/base.yaml Adds Connectors image.pullSecrets for Docker Hub + Camunda Cloud registry in chart-full-setup base values.
charts/camunda-platform-8.8/test/integration/scenarios/chart-full-setup/values/base.yaml Same Connectors pull secret addition for 8.8 chart-full-setup base values.
charts/camunda-platform-8.9/test/integration/scenarios/chart-full-setup/values/base.yaml Same Connectors pull secret addition for 8.9 chart-full-setup base values.
charts/camunda-platform-8.10/test/integration/scenarios/chart-full-setup/values/base.yaml Same Connectors pull secret addition for 8.10 chart-full-setup base values.

@eamonnmoloney eamonnmoloney enabled auto-merge June 25, 2026 10:39
…ents

The connectors fix addressed only one of several camunda-image components
that hit ImagePullBackOff when their image is overridden to a
registry.camunda.cloud build. Because camundaPlatform.subChartImagePullSecrets
replaces (not merges) global.image.pullSecrets, every component without an
explicit registry-camunda-cloud entry authenticates to the Camunda registry
anonymously and fails to pull.

Mirror the connectors/webModeler/console pattern for the remaining camunda
components in chart-full-setup/values/base.yaml:
- 8.8-8.10: identity, optimize, orchestration
- 8.7 (pre-unified): identity, operate, optimize, tasklist, zeebe, zeebeGateway

Values-file-only change; no chart templates touched, so no golden snapshots
are affected. Verified: helm lint passes for all four versions and
helm template renders both index-docker-io and registry-camunda-cloud on
every camunda workload.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@eamonnmoloney eamonnmoloney changed the title test: add registry-camunda-cloud pull secret to connectors integration values test: add registry-camunda-cloud pull secret to camunda component integration values Jun 25, 2026
@eamonnmoloney eamonnmoloney added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 5e5ac76 Jun 26, 2026
268 checks passed
@eamonnmoloney eamonnmoloney deleted the fix/connectors-integration-pull-secret branch June 26, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version/8.7 Camunda applications/cycle version version/8.8 Camunda applications/cycle version version/8.9 Camunda applications/cycle version version/8.10 Camunda applications/cycle version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants