test: replace weak literal connectors password with secretKeyRef in multitenancy scenario#6467
Open
eamonnmoloney wants to merge 1 commit into
Open
test: replace weak literal connectors password with secretKeyRef in multitenancy scenario#6467eamonnmoloney wants to merge 1 commit into
eamonnmoloney wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the multitenancy integration-test scenario values to avoid GKE admission rejection (deny-weak-password-defaults) by replacing a weak literal password env var value with a valueFrom.secretKeyRef pointing to the existing integration-test-credentials Secret. This is applied consistently across chart versions 8.6–8.10.
Changes:
- Replace
connectors.envliteralvalue: passwordwithvalueFrom.secretKeyRef(integration-test-credentials/password). - Apply the same change across all affected chart versions (8.6, 8.7, 8.8, 8.9, 8.10).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/camunda-platform-8.6/test/integration/scenarios/chart-full-setup/values/features/multitenancy.yaml | Switch connectors password env var to Secret-backed valueFrom for the 8.6 scenario. |
| charts/camunda-platform-8.7/test/integration/scenarios/chart-full-setup/values/features/multitenancy.yaml | Switch connectors password env var to Secret-backed valueFrom for the 8.7 scenario. |
| charts/camunda-platform-8.8/test/integration/scenarios/chart-full-setup/values/features/multitenancy.yaml | Switch connectors password env var to Secret-backed valueFrom for the 8.8 scenario. |
| charts/camunda-platform-8.9/test/integration/scenarios/chart-full-setup/values/features/multitenancy.yaml | Switch connectors password env var to Secret-backed valueFrom for the 8.9 scenario. |
| charts/camunda-platform-8.10/test/integration/scenarios/chart-full-setup/values/features/multitenancy.yaml | Switch connectors password env var to Secret-backed valueFrom for the 8.10 scenario. |
…ultitenancy scenario The GKE CI cluster has a ValidatingAdmissionPolicy (deny-weak-password-defaults) that rejects Deployments where a password-named env var is set to a known default or a value shorter than 12 characters. The connectors env var `password: password` was triggering this policy, causing the kemt (keycloak-mt) scenario to fail on Helm install across all chart versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a150a31 to
bb2172c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Fixes the failing
kemt(keycloak-mt) scenario in the merge queue for #6463.The GKE CI cluster enforces a
ValidatingAdmissionPolicy(deny-weak-password-defaults) that rejects any Deployment where a password-named env var is set to a known default or a value shorter than 12 characters. The multitenancy scenario values setconnectors.env[].name: password, value: password, which triggers the policy and causes Helm install to fail immediately with:What's in this PR?
Replace the literal
value: passwordwith asecretKeyRefpointing to theintegration-test-credentialssecret (already provisioned in every integration test namespace via External Secrets). Thepasswordkey in that secret holds a strong, Vault-managed password.Applied to all five affected chart versions: 8.6, 8.7, 8.8, 8.9, 8.10.
Checklist
Before opening the PR:
make go.update-golden-only.After opening the PR: