Conversation
59772ef to
7ea9119
Compare
megglos
commented
Feb 12, 2022
| env: | ||
| DISTRO: ${{ matrix.DISTRO }} | ||
| EE: false | ||
| PLATFORMS: linux/arm64,linux/amd64 |
Author
There was a problem hiding this comment.
this just achieves making the final images pushed multiarch so the test pipeline is actually not making use of those, leaving the chance for undetected broken arm64 images.
Testing of each arch is a bit more tricky to achieve as we would need to also use qemu to test non amd64 images, something like https://github.com/uraimo/run-on-arch-action might be helpful, but this one doesn't support the amd64 arch yet, however they are working on it: uraimo/run-on-arch-action#58
9912ed7 to
3b669bf
Compare
|
When will this be merged? Would be great to have the arm image for the Apple Silicon. |
|
Waiting for this to get merged, the x86 image isn't usable on Apple Silicon |
3 tasks
Author
|
closing as this will be done by the platform team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP not ready yet.
Would resolve #205
Relates to #CAM-14301
See
https://docs.docker.com/buildx/working-with-buildx/#build-multi-platform-images
https://docs.docker.com/ci-cd/github-actions/
https://github.com/docker/setup-buildx-action#with-qemu