Categorize built-ins / expose reserved name built-ins#20
Merged
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR restructures the exported FEEL builtin collections to separate standard FEEL builtins from Camunda-specific extensions, and adds a build-time step to detect functions that are not parsable by lezer-feel (supporting downstream editor/lint integrations).
Changes:
- Split exports into
feelBuiltins,camundaExtensions,camundaBuiltins(combined), plusunparsableBuiltins. - Refactor the builtin compilation task into smaller utilities (markdown parsing, categorization, template writing) and add
lezer-feel-based parsability detection. - Update README, typings, and tests to reflect the new exports.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Enables skipLibCheck for TS checking. |
| package.json | Adds @bpmn-io/lezer-feel dependency for parsability detection during compilation. |
| package-lock.json | Locks new dependency tree for @bpmn-io/lezer-feel. |
| tasks/compileBuiltins.js | Uses new utils + categorization and writes categorized outputs via template. |
| tasks/camundaBuiltins.template.js | Template now defines separate exports and composes camundaBuiltins. |
| tasks/utils/index.js | Barrel export for the new task utilities. |
| tasks/utils/markdownParser.js | New markdown parsing utility extracted from compile script. |
| tasks/utils/parseBuiltins.js | Updates JSDoc types to use the new markdown parser typedef. |
| tasks/utils/categorizeBuiltins.js | Adds Lezer-based parsability detection and categorization logic. |
| tasks/utils/templateWriter.js | New utility to write categorized lists into the JS template. |
| src/index.js | Exposes the new public exports. |
| src/camundaBuiltins.js | Regenerated output containing split builtin collections and unparsables list. |
| dist/index.d.ts | Updates public typings for new exports. |
| test/spec/lib/camundaBuiltins.spec.js | Adds test coverage for the new exports and relationships. |
| README.md | Documents the new exports and suggested usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
nikku
reviewed
Feb 9, 2026
nikku
reviewed
Feb 9, 2026
nikku
reviewed
Feb 9, 2026
nikku
reviewed
Feb 9, 2026
nikku
reviewed
Feb 9, 2026
nikku
reviewed
Feb 9, 2026
Member
nikku
left a comment
There was a problem hiding this comment.
Some comments attached, sorry for potential double posts (due to GitHub hick-ups).
nikku
reviewed
Feb 10, 2026
| function isParsable(builtin) { | ||
| try { | ||
| const paramsList = builtin.params?.map((p) => 'null').join(', ') || ''; | ||
| const expression = `${builtin.name}(${paramsList})`; |
Member
|
Thanks again, released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Related to camunda/camunda-modeler#3983
Proposed Changes
get or elseCamunda FEEL function is marked as syntax error camunda-modeler#3983)So far only
get or elseis an unparsable function. but with this we can detect more in the future.Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}