Skip to content

refactor: extend is empty() to check if a string is empty #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: extend is empty() to check if a string is empty #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/scala/org/camunda/feel/impl/builtin/ListBuiltinFunctions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,9 @@ class ListBuiltinFunctions(private val valueMapper: ValueMapper) {
private def emptyFunction =
builtinFunction(
params = List("list"),
invoke = { case List(ValList(list)) =>
ValBoolean(list.isEmpty)
invoke = {
case List(ValString(list)) => ValBoolean(list.isEmpty)
case List(ValList(list)) => ValBoolean(list.isEmpty)
}
)

Expand Down
22 changes: 21 additions & 1 deletion src/test/scala/org/camunda/feel/impl/builtin/BuiltinListFunctionsTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,11 +563,31 @@ class BuiltinListFunctionsTest
evaluateExpression(""" string join(["foo", 123, "bar"]) """) should returnNull()
}

"A list is empty() function" should "return if the list is empty" in {
"A list or string is empty() function" should "return Boolean" in {

evaluateExpression(" is empty([]) ") should returnResult(true)
evaluateExpression(" is empty([1]) ") should returnResult(false)
evaluateExpression(" is empty([1,2,3]) ") should returnResult(false)
evaluateExpression(" is empty(list: [1]) ") should returnResult(false)

evaluateExpression(
expression = """ is empty("") """
) should returnResult(true)

evaluateExpression(
expression = """ is empty(" ") """
) should returnResult(false)

evaluateExpression(
expression = """ is empty("hello world") """
) should returnResult(false)

evaluateExpression(
expression = """ is empty(" hello world ") """
) should returnResult(false)

evaluateExpression(
expression = """ is empty("\t\n\r\f") """
) should returnResult(false)
}
}