Skip to content

feat: add new fossa-related composite actions #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

feat: add new fossa-related composite actions #399

merged 1 commit into from
May 13, 2025

Conversation

clementnero
Copy link
Contributor

@clementnero clementnero commented May 7, 2025

Related to https://github.com/camunda/team-infrastructure/issues/752.

Add new fossa-related composite actions to check PRs for newly introduced issues. It currently only handle license issues, but can be extended to security issues later.

The fossa/pr-check action relies on the fossa test command and includes a License Policy guard step, which fails if the PR introduces a new license issue and add an annotation to the job for visibility.

@clementnero clementnero force-pushed the fossa branch 6 times, most recently from f798245 to 7f9e272 Compare May 12, 2025 13:41
@clementnero clementnero requested a review from kellervater May 13, 2025 07:10
Copy link
Member

@kellervater kellervater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :-D
I like the annotation approach.
Left a clarification question about the reasoning to go with a custom implementation.
If my concerns are non-applicable, please feel free to merge this PR as it is a well-crafted addition to our global actions.

@clementnero clementnero merged commit 24523ca into main May 13, 2025
1 check passed
@clementnero clementnero deleted the fossa branch May 13, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants