feat: fixate versions in gh action and mbt build version#81
Open
monavari-lebrecht wants to merge 5 commits into
Open
feat: fixate versions in gh action and mbt build version#81monavari-lebrecht wants to merge 5 commits into
monavari-lebrecht wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts two reusable GitHub Actions workflows that support the repo's CI validation and BTP deployment pipeline, aiming to make dependency/tool execution more deterministic.
Changes:
- Simplifies the reusable test workflow's dependency installation step to run a plain
npm ci. - Pins the deploy workflow's MBT invocation to
mbt@1.2.49. - Keeps the overall test and deploy flow unchanged while tightening how dependencies/tools are resolved.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/reusable_test.yml |
Replaces the previous install-and-retry block with a single npm ci step in the reusable test workflow. |
.github/workflows/reusable_deploy-to-btp.yml |
Changes the MTAR build step to invoke a version-pinned MBT package via npx. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: build mtar | ||
| run: npx mbt build | ||
| run: npx mbt@1.2.49 build |
| rm -rf node_modules package-lock.json */node_modules */package-lock.json | ||
| npm i --include=optional --no-audit --no-fund | ||
| } | ||
| run: npm ci |
|
|
|
|
| "e2e:test:deployForms": "./_misc/deployForms.sh fiori-app/webapp/test/playwrightE2E/controls/camunda fiori-app/webapp/test/playwrightE2E/misc/camunda", | ||
| "gh:test": "act workflow_dispatch -W .github/workflows/webapp-e2e-tests-on-demand.yml --input version=8.7 -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest" | ||
| }, | ||
| }, |
Comment on lines
117
to
121
| // maxInstances can get overwritten per capability. So if you have an in-house Selenium | ||
| // grid with only 5 firefox instances available you can make sure that not more than | ||
| // 5 instances get started at a time. | ||
| // maxInstances: 5, | ||
| maxInstances: 1, | ||
| browserName: "chrome", |
Comment on lines
+53
to
+54
| echo "Installing $ROLLUP_PKG" | ||
| npm i --no-save "$ROLLUP_PKG" |
Comment on lines
+90
to
+92
| # Non-standalone setups (8.8/8.9) require DATABASE for compose interpolation. | ||
| if [[ "${{ matrix.non_standalone }}" != "true" ]]; then | ||
| echo "DATABASE=elasticsearch" >> "$GITHUB_ENV" |
Comment on lines
+53
to
+54
| echo "Installing $ROLLUP_PKG" | ||
| npm i --no-save "$ROLLUP_PKG" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.