Skip to content

refactor(common): move RESP type constants from resp to common package #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cankush625 merged 1 commit into from
May 6, 2026
Merged

refactor(common): move RESP type constants from resp to common package #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions common/grammar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package common

// RESP data type names
const SimpleString = "SIMPLE_STRING"
const SimpleError = "SIMPLE_ERROR"
const Integer = "INTEGER"
const BulkString = "BULK_STRING"
const Array = "ARRAY"
16 changes: 5 additions & 11 deletions resp/grammar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,12 @@ package resp

import "HelixDB/common"

const SimpleString = "SIMPLE_STRING"
const SimpleError = "SIMPLE_ERROR"
const Integer = "INTEGER"
const BulkString = "BULK_STRING"
const Array = "ARRAY"

var DataTypeToFirstByteMap = map[string]string{
"+": SimpleString,
"-": SimpleError,
":": Integer,
"$": BulkString,
"*": Array,
"+": common.SimpleString,
"-": common.SimpleError,
":": common.Integer,
"$": common.BulkString,
"*": common.Array,
}

var FirstByteToDataTypeMap = common.ReverseMap(DataTypeToFirstByteMap)
2 changes: 1 addition & 1 deletion resp/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func ParseCommand(command []byte) (common.Cmd, error) {
return common.Cmd{}, UnsupportedCommandDataTypeError
}
data := strings.Split(string(command), common.Terminator)
if dataType == Array {
if dataType == common.Array {
return parseArray(data)
}
return common.Cmd{}, nil
Expand Down
Loading