Skip to content

Conversation

@petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Jun 4, 2025

Done

  • feat: Migrate pages from u.com
  • feat: Update navigation
  • feat: Migrate the managed modal form

Notes

QA

  • Check out the demo
  • Check it matches the u.com/managed bubble
  • Check the navigation link has been updated, copydoc
  • Check the secondary nav matches and functions correctly

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-22525

@webteam-app
Copy link

@petesfrench petesfrench changed the base branch from main to managed-feature-branch June 4, 2025 09:07
@muhammad-ali-pk muhammad-ali-pk self-assigned this Jun 4, 2025
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petesfrench. Left a couple comments.

PS., can you please share why the static sitemap files were deleted?

@petesfrench
Copy link
Contributor Author

petesfrench commented Jun 4, 2025

@muhammad-ali-pk I have updated the relative links you flagged as broken, can you take another look please.

R.e. the removal of hardcoded sitemaps: Our sitemaps are generated dynamically, see here

Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petesfrench! Just two small things.

  1. Can you please remove the space between image and ( for the image module references, and reformat the files?
  2. Looks like the ceph page is missing a body class is-paper which is present on the rest of pages on this bubble. Can you please add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants