-
Notifications
You must be signed in to change notification settings - Fork 108
Migrate u.com/managed to c.com/managed #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: managed-feature-branch
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @petesfrench. Left a couple comments.
PS., can you please share why the static sitemap files were deleted?
|
@muhammad-ali-pk I have updated the relative links you flagged as broken, can you take another look please. R.e. the removal of hardcoded sitemaps: Our sitemaps are generated dynamically, see here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @petesfrench! Just two small things.
- Can you please remove the space between
imageand(for the image module references, and reformat the files? - Looks like the ceph page is missing a body class
is-paperwhich is present on the rest of pages on this bubble. Can you please add it?
Done
Notes
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-22525