Skip to content

Conversation

@rubinaga
Copy link
Contributor

@rubinaga rubinaga commented Oct 21, 2025

Done

  • make contact us form open in modal if javascript is enabled
  • update optional fields in contact form

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8002/
  • View the site in the demo site: https://canonical-com-2021.demos.haus/maas
    • Check that the modal is opened when javascript is enabled, and the redirect when javascript is disabled
    • Check the form fields match the copy doc

Issue / Card

Jira ticket WD-30134
Copy doc
Fixes #

  • "Contact us" modal not opening when javascript is enabled

Screenshots

image image

@webteam-app
Copy link

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.70%. Comparing base (8192c24) to head (6af5ca4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2021   +/-   ##
=======================================
  Coverage   76.70%   76.70%           
=======================================
  Files          16       16           
  Lines        1588     1588           
=======================================
  Hits         1218     1218           
  Misses        370      370           
Flag Coverage Δ
python 76.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rubinaga, I think there are a couple of things that need addressing here.

In the copy doc there is a "Tell us about your project" field that is missing from the current form so maybe that needs adding as well?

Also, on the non-modal version the heading and intro paragraph are duplicated in the header and then above the form:

Image

@rubinaga rubinaga force-pushed the WD-30134 branch 3 times, most recently from e657a57 to 973bf47 Compare October 22, 2025 11:02
@rubinaga rubinaga requested a review from huwshimi October 22, 2025 13:37
Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @rubinaga!

@rubinaga rubinaga merged commit 990c0ac into main Oct 24, 2025
12 checks passed
@rubinaga rubinaga deleted the WD-30134 branch October 24, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants