Update security pipeline and permissions (infra) #1769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
force-pushed
the
update_security_pipeline
branch
from
2c9ea6b to
ae7a9fc
Compare
Hook25
force-pushed
the
update_security_pipeline
branch
from
ae7a9fc to
7f07a79
Compare
pieqq
approved these changes
Mar 6, 2025
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
This is pretty hard to test as is, let's land it and see what breaks, as you said.
stanley31huang
pushed a commit
that referenced
this pull request
Mar 28, 2025
* Update to zizmor latest * Add workflow permission contents: read to all workflows * Propagate secrets explicitly * Also inherit credentials for ce-oem * Fine grained validate_workflow access * Also set permissions for testlinger workflow * Also give access to actions beta release pipeline * Give additional access to actions * Move the permission to a workflow level
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Update to zizmor latest * Add workflow permission contents: read to all workflows * Propagate secrets explicitly * Also inherit credentials for ce-oem * Fine grained validate_workflow access * Also set permissions for testlinger workflow * Also give access to actions beta release pipeline * Give additional access to actions * Move the permission to a workflow level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating our security scanning tool zizmor to
1.4.1I discovered a few new warnings that it finds. The following updates the tool and fixes all the warnings.This may break a few pipelines, but we can fix them once we find them, the GH documentation about permissions is very bad and unclear about what each thing needs.
Resolved issues
Fixes: CHECKBOX-1774
Documentation
N/A
Tests
N/A