Removed custom implementation and using cv2 (BugFix) #1776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some weird reason, when the two images were the same, the tests were failing in later versions of python (3.13), but not in early ones. This was probably due to a rounding error.
Nevertheless, the implementation of the algorithm was wrong, and it returned 0 instead of a big value if the images were exactly the same.
I've just changed it to use the default one from opencv (
cv2.PSNR)Resolved issues
Documentation
Tests
Tested with python 3.13