-
Notifications
You must be signed in to change notification settings - Fork 74
Launcher support provider (new) #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Forgotten launcher unit
Minor: fix bug in resolve_configs not using launcher config name
This also fixes a bug that was previously here, as in, the launcher in the controller was previously un-resolved, and it could have therefore different values from the agent if the values were defined in a global conf
Minor: comment above the resolver that it doesn't make sense to resolve
on the controller machine
Minor: fix typo in docstring
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (78.37%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
+ Coverage 53.34% 53.45% +0.11%
==========================================
Files 399 400 +1
Lines 42907 43036 +129
Branches 7945 7277 -668
==========================================
+ Hits 22887 23004 +117
- Misses 19214 19232 +18
+ Partials 806 800 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Checksum is used to see if a unit is already in the session
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in a week. |
Description
Sharing launchers is often useful to get less technical users to use the product correctly and to have a easier pre-baked input for projects. There was up until now a mechanism in checkbox to share these files so the two solutions that were employed were:
The first solution doesn't work for snaps and the second solution doesn't work for debs. Both solution can't be used with checkbox remote. Additionally, both will not work with the new
custom-frontendinterface.This introduces the concept of Launchers in the whole Checkbox ecosystem, from packaging to units, creating a new location where these provider-specific launchers live (
provider/launchers), a standard way to use them (via their FQN, more below!), a standard way to list them (checkbox-cli list launcher) and a cleaner way (in name, mechanism is unchanged) to inherit from other configurations.Resolved issues
Documentation
WIP
Tests
Unit tests + try the following