-
Notifications
You must be signed in to change notification settings - Fork 71
Launcher support provider (new) #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Hook25
wants to merge
23
commits into
main
Choose a base branch
from
launcher_support_provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgotten launcher unit
Minor: fix bug in resolve_configs not using launcher config name
This also fixes a bug that was previously here, as in, the launcher in the controller was previously un-resolved, and it could have therefore different values from the agent if the values were defined in a global conf
Minor: comment above the resolver that it doesn't make sense to resolve
on the controller machine
Minor: fix typo in docstring
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
+ Coverage 53.34% 53.45% +0.11%
==========================================
Files 399 400 +1
Lines 42907 43036 +129
Branches 7945 7277 -668
==========================================
+ Hits 22887 23004 +117
- Misses 19214 19232 +18
+ Partials 806 800 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Checksum is used to see if a unit is already in the session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sharing launchers is often useful to get less technical users to use the product correctly and to have a easier pre-baked input for projects. There was up until now a mechanism in checkbox to share these files so the two solutions that were employed were:
The first solution doesn't work for snaps and the second solution doesn't work for debs. Both solution can't be used with checkbox remote. Additionally, both will not work with the new
custom-frontendinterface.This introduces the concept of Launchers in the whole Checkbox ecosystem, from packaging to units, creating a new location where these provider-specific launchers live (
provider/launchers), a standard way to use them (via their FQN, more below!), a standard way to list them (checkbox-cli list launcher) and a cleaner way (in name, mechanism is unchanged) to inherit from other configurations.Resolved issues
Documentation
WIP
Tests
Unit tests + try the following