DMI sane_product missing Mini PC and fix AIO for related jobs (BugFix) #2204
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 53.49% 53.56% +0.06%
==========================================
Files 401 401
Lines 43079 43102 +23
Branches 7983 7991 +8
==========================================
+ Hits 23045 23086 +41
+ Misses 19223 19205 -18
Partials 811 811
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hanhsuan
requested changes
Nov 18, 2025
Contributor
hanhsuan
left a comment
hanhsuan
left a comment
There was a problem hiding this comment.
Could we have one new sane_product type to collect AIO to prevent the naming issue in the future ?
clairlin53
changed the title
clairlin53
changed the title
hanhsuan
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for the PR Dmi resource sane_product to avoid in duplication (bugfix) #2046
Problem
Bug: resource.py file is missing the "Mini PC" type, causing desktop jobs to be skipped.
Bug: Graphics jobs and DIM job are skipped on AIO devices due to flawed "portable" refactor.
Description
Resolved issues
Documentation
Tests
Mini PC
Fail Result:
Manual Test:
https://certification.canonical.com/hardware/202505-36800/submission/458592/test-results/?term=glxgears
Auto Test:
https://certification.canonical.com/hardware/202505-36800/submission/456750/test-results/?term=glxgears
After modified (PASS):
Manual Test:
https://certification.canonical.com/hardware/202505-36800/submission/459713/
Auto Test:
https://certification.canonical.com/hardware/202505-36800/submission/459717/
AIO
Fail Result:
Manual:
https://certification.canonical.com/hardware/202508-37860/submission/456492/test-results/?term=dim
https://certification.canonical.com/hardware/202508-37860/submission/456492/test-results/?term=glxgears
Auto:
https://certification.canonical.com/hardware/202508-37860/submission/456467/test-results/?term=glxgears
After modified (PASS):
Manual Test:
https://certification.canonical.com/hardware/202508-37860/submission/459705/
https://certification.canonical.com/hardware/202508-37850/submission/459704/
https://certification.canonical.com/hardware/202508-37860/submission/459958/
Auto Test:
https://certification.canonical.com/hardware/202508-37860/submission/459708/
https://certification.canonical.com/hardware/202508-37860/submission/459956/