Skip to content

Conversation

@Artur-at-work
Copy link
Contributor

@Artur-at-work Artur-at-work commented Nov 19, 2025

Description

Refactor bios-error.sh script in Python and added unit tests to follow the requirements from providers/base. This script still in contrib/pc-sanity to verify change didn't break the logic. After several pc-sanity releases, this can be candidate to PR into base provider.

Resolved issues

Closes https://warthogs.atlassian.net/browse/OEX86-876

Documentation

Tests

On local, use manage.py inside provider

$ ./manage.py test
.........................................................................................................
----------------------------------------------------------------------
Ran 105 tests in 3.774s

OK

$ ./manage.py test -k acpi_bios_error -v
test_flake8_/home/artur/workspace/checkbox/contrib/pc-sanity/bin/acpi_bios_error.py (plainbox.provider_manager.Flake8Tests.test_flake8_/home/artur/workspace/checkbox/contrib/pc-sanity/bin/acpi_bios_error.py) ... ok
test_check_acpi_bios_errors_found (test_acpi_bios_error.TestAcpiBiosError.test_check_acpi_bios_errors_found)
Test when ACPI BIOS errors are detected. ... ok
test_check_acpi_bios_errors_no_errors (test_acpi_bios_error.TestAcpiBiosError.test_check_acpi_bios_errors_no_errors)
Test when no ACPI BIOS errors are found. ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.216s

OK

On DUT, update provider and plan, then run with checkbox-cli

------------------------------------------------------------------------ >8 ---
Outcome: job passed
========[ Running job 28 / 28. Estimated time left (at least): 0:00:00 ]========
------------------[ Check if kernel reports ACPI BIOS Error ]-------------------
ID: com.canonical.certification::miscellanea/acpi-bios-error_GenuineIntel
Category: com.canonical.plainbox::miscellanea
... 8< -------------------------------------------------------------------------
No ACPI BIOS errors detected in current boot
------------------------------------------------------------------------- >8 ---
Outcome: job passed

@Artur-at-work Artur-at-work requested a review from a team as a code owner November 19, 2025 06:09
@Artur-at-work Artur-at-work marked this pull request as draft November 19, 2025 06:16
@Artur-at-work Artur-at-work marked this pull request as ready for review November 19, 2025 06:28
Copy link
Contributor

@pseudocc pseudocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st comment: request changes.
2nd comment: okay to leave it unchanged, but recommend.

@Artur-at-work Artur-at-work marked this pull request as draft November 19, 2025 07:28
@Artur-at-work Artur-at-work marked this pull request as ready for review November 20, 2025 06:04
Copy link
Contributor

@pseudocc pseudocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

Copy link
Contributor

@xanthein xanthein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Artur-at-work Artur-at-work merged commit 86363a0 into canonical:main Nov 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants