-
Notifications
You must be signed in to change notification settings - Fork 74
Refactor bios error test script with python and add unit tests (New) #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st comment: request changes.
2nd comment: okay to leave it unchanged, but recommend.
pseudocc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
xanthein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Description
Refactor bios-error.sh script in Python and added unit tests to follow the requirements from providers/base. This script still in contrib/pc-sanity to verify change didn't break the logic. After several pc-sanity releases, this can be candidate to PR into base provider.
Resolved issues
Closes https://warthogs.atlassian.net/browse/OEX86-876
Documentation
Tests
On local, use manage.py inside provider
On DUT, update provider and plan, then run with checkbox-cli