Systemd based runner default on core (bugfix) #2247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current subshell runner will be broken on core (in some scenarios) starting 6Jan with the release of snapd beta to stable. This comes in the form of a cgroup tracking error when calling a snap from a snap like the following:
For this reason we must make the new systemd-based runner default on core. Note that the option to use the old runner will remain via the feature flag as the value from the user will always be respected. This only changes the default value from
False(never enabled by default) toNone(sometimes enabled by default).This PR also updates the build repo for
plz-runto my Github fork (pending move under the Canonical org) as we need to be able to update this tool while the maintainer is OOO. Note that this is necessary as I have landed a bugfix there.Finally this pr also adds a small bugfix (there is a typo in the PAM module to use, to double check simply ls
/etc/pam.d, there is nosystemd-login, itssystem-login!)Resolved issues
Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-2142
Documentation
N/A
Tests
Tested this locally to verify the bugfix fixes the regressions reported by QA.
Snap builds: