Use type instead of name in thermal sensor tests (Bugfix) #2311
+43
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbhat
force-pushed
the
bnbhat/thermal-zone-fix-1
branch
2 times, most recently
from
07d876c to
a9e2ead
Compare
Thermal zone indices can change across reboots, making name-based identification unreliable. This change uses the zone type field instead, ensuring consistent test execution. Additionally, thermal zone interfaces are sometimes repurposed for monitoring non-thermal parameters (e.g., voltages on Qualcomm RB3, RB8 platforms). These edge cases are excluded from test plans using regex patterns matched against the type field. When both pre-suspend and after-suspend tests are generated from templates, a watchdog-triggered reboot can cause zone index changes, invalidating regex exclusions based on zone names and causing previously excluded tests to run unexpectedly.
bnbhat
force-pushed
the
bnbhat/thermal-zone-fix-1
branch
from
a9e2ead to
17767ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thermal zone indices can change across reboots, making name-based identification unreliable. This change uses the zone type field instead, ensuring consistent test execution.
Additionally, thermal zone interfaces are sometimes repurposed for monitoring non-thermal parameters (e.g., voltages on Qualcomm RB3, RB8 platforms). These edge cases are excluded from test plans using regex patterns matched against the type field.
When both pre-suspend and after-suspend tests are generated from templates, a watchdog-triggered reboot can cause zone index changes, invalidating regex exclusions based on zone names and causing previously excluded tests to run unexpectedly.
This PR makes the test use
typesuch ascpu5-thermalinstead of indexthermal_zone8Resolved issues
https://warthogs.atlassian.net/browse/PECA-1263