Skip to content

Fix RVS confinement issues (BugFix)#2391

Merged
pedro-avalos merged 5 commits intomainfrom
fix-rvs-snap-common
Mar 17, 2026
Merged

Fix RVS confinement issues (BugFix)#2391
pedro-avalos merged 5 commits intomainfrom
fix-rvs-snap-common

Conversation

@pedro-avalos
Copy link
Copy Markdown
Collaborator

@pedro-avalos pedro-avalos commented Mar 16, 2026

Description

  • The ROCm Validation Suite snap is strictly confined, so it can't access the configuration templates in /usr/share (where the checkbox deb stores the data files)
    • Previously, the script would run the snap unconfined, but that leads to issues with dependencies/libraries that the snap bundles in, but may not be installed on the system (the LD_LIBRARY path of the snap would not be included with this hack)
    • Based on Add DPDK Provider (New) #2384, I have changed this behavior to copy the config files to the snap common directory when using the RVS snap; however, since these tests are not run by root user, the common directory is the one in home, rather than /var

Resolved issues

Documentation

Tests

even though most IDEs handle this, it's not covered by the PEP specifying docstrings and their uses
this is much better than the hack of running the snap binary unconfined (which leads to library/dependency issues)
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.73%. Comparing base (3128237) to head (2d9abff).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
- Coverage   57.73%   57.73%   -0.01%     
==========================================
  Files         467      467              
  Lines       47268    47267       -1     
  Branches     8411     8411              
==========================================
- Hits        27292    27291       -1     
  Misses      19092    19092              
  Partials      884      884              
Flag Coverage Δ
provider-gpgpu 93.12% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pedro-avalos pedro-avalos marked this pull request as ready for review March 16, 2026 19:44
@pedro-avalos pedro-avalos changed the title Copy RVS configuration to Snap common directory (BugFix) Fix RVS confinement issues (BugFix) Mar 16, 2026
@pedro-avalos pedro-avalos merged commit b196516 into main Mar 17, 2026
41 checks passed
@pedro-avalos pedro-avalos deleted the fix-rvs-snap-common branch March 17, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants