Remove qr tests (New)

[fernando79513]

Description

We have replaced the Raspberry Pi camera QR roundtrip test with a BRISQUE-based camera quality test, and cleaned up the related camera job definitions and packaging. This test will be run in versions of core >=20. Since the quality test is using opencv, we have included the opencv page also for core20 snaps.

Changes

• Removed the camera/roundtrip-qrcode_* job and deleted providers/base/bin/roundtrip_qr.py

• Added an RPi-specific camera quality job to the camera test plan:

  • camera/camera-quality-rpi_{name}

• Adjusted the RPi attachment job to use the new per-device image naming

• Updated snap dependencies:

  • Added python3-opencv and libsvm3 to core20 snaps for camera quality
  • removed python3-pyqrcode

Resolved issues

https://warthogs.atlassian.net/browse/CHECKBOX-2193

Documentation

Not changed

Tests

Run the camera tests on rpi3b running core 20:
https://certification.canonical.com/hardware/201810-26542/submission/478516/

Run the camera tests on rpi4b2g running core 22:
http://certification.canonical.com/hardware/201911-27507/submission/478638/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.89%. Comparing base (3128237) to head (641fc42).
⚠️ Report is 141 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
+ Coverage   57.73%   57.89%   +0.15%     
==========================================
  Files         467      467              
  Lines       47268    47224      -44     
  Branches     8411     8409       -2     
==========================================
+ Hits        27292    27342      +50     
+ Misses      19092    18998      -94     
  Partials      884      884              

Flag	Coverage Δ
provider-base	32.91% <100.00%> (+0.38%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Replaces the Raspberry Pi camera QR-code roundtrip test with an RPi-specific BRISQUE-based camera quality test, and updates the related job definitions and snap dependencies.

Changes:

• Removed the roundtrip-qrcode job and deleted the supporting roundtrip_qr.py script.
• Added an RPi-specific camera-quality-rpi job and updated RPi image attachment naming to be per-device.
• Updated snap dependencies (remove python3-pyqrcode; add python3-opencv/libsvm3 to core20).

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
providers/base/units/camera/test-plan.pxu	Switches test plan inclusion from QR roundtrip to the new RPi quality job (but currently uses an include that won’t match generated job ids).
providers/base/units/camera/packaging.pxu	Removes packaging metadata dependencies associated with the removed QR job.
providers/base/units/camera/jobs.pxu	Adds camera/camera-quality-rpi_{name} and updates RPi attachment logic and filters.
providers/base/units/camera/README.rst	Removes mention of roundtrip-qrcode from documentation.
providers/base/bin/roundtrip_qr.py	Deletes the QR roundtrip implementation script.
providers/base/bin/camera_test_rpi.py	Changes captured image naming to include the device identifier.
checkbox-core-snap/series20/snap/snapcraft.yaml	Adds python3-opencv/libsvm3 and removes python3-pyqrcode for core20 snaps.
checkbox-core-snap/series22/snap/snapcraft.yaml	Removes python3-pyqrcode from core22 snaps.
checkbox-core-snap/series24/snap/snapcraft.yaml	Removes python3-pyqrcode from core24 snaps.

Comments suppressed due to low confidence (3)

checkbox-core-snap/series22/snap/snapcraft.yaml:392

• With the QR roundtrip test removed (and python3-pyqrcode dropped), python3-zbar appears to be unused in the repository now. Consider removing it from stage-packages as well to reduce snap size, unless it’s required by some other runtime component.

      - python3-psutil
      - python3-serial
      - python3-yaml
      - python3-pyscard
      - python3-zbar

checkbox-core-snap/series24/snap/snapcraft.yaml:393

• With the QR roundtrip test removed (and python3-pyqrcode dropped), python3-zbar appears to be unused in the repository now. Consider removing it from stage-packages as well to reduce snap size, unless it’s required by some other runtime component.

      - python3-psutil
      - python3-serial
      - python3-yaml
      - python3-pyscard
      - python3-zbar

checkbox-core-snap/series20/snap/snapcraft.yaml:388

• With the QR roundtrip test removed (and python3-pyqrcode dropped), python3-zbar appears to be unused in the repository now. Consider removing it from stage-packages as well to reduce snap size, unless it’s required by some other runtime component.

      - python3-psutil
      - python3-serial
      - python3-yaml
      - python3-pyscard
      - python3-zbar

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pieqq]

Just one little request in the doc.

Did you try to build the snaps to check if the build process worked OK?

[fernando79513]

I built the snaps here:
https://github.com/canonical/checkbox/actions/runs/23244520055