Conversation
Minor: Add LICENSE and CHANGELOG to sdist
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
=======================================
Coverage 57.76% 57.76%
=======================================
Files 467 467
Lines 47299 47299
Branches 8419 8419
=======================================
Hits 27321 27321
Misses 19092 19092
Partials 886 886
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fernando79513
approved these changes
Mar 18, 2026
fernando79513
left a comment
fernando79513
left a comment
Collaborator
There was a problem hiding this comment.
I read it and everything looks fine.
Most importantly, the CI failed when it should fail and passed when it should pass.
LGTM +1!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MANIFEST.in inclusions are a recurrent rake we step on. For this reason, this adds CI that checks if a file that was added to
checkbox-supportorcheckbox-ngis correctly included or excluded from the manifest.The reason why we only see this issue in debian builds or snapcraft remote builds is because if
.gitis shipped to the build env,setuptools-scmautomatically uses it to know what to include. In these two environments.gitis not present, so we fallback to MANIFEST and we fail to build.Additionally this forces us to take into consideration all additions from this lens. This also caught another problem, we weren't shipping the LICENSE for some vendorized dependencies
Resolved issues
Fixes: CER-3481
Documentation
N/A
Tests
This should fail first PR push, rebase on main should pass after this lands