Change certification level status (BugFix)#2424
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2424 +/- ##
==========================================
+ Coverage 58.86% 58.89% +0.03%
==========================================
Files 476 476
Lines 48007 48007
Branches 8570 8570
==========================================
+ Hits 28260 28276 +16
+ Misses 18855 18839 -16
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b0426d to
0ab0e2d
Compare
pieqq
left a comment
There was a problem hiding this comment.
The modifications made here affect nested parts that are used for different versions of Ubuntu.
In particular, it modifies the certification status of 24.04 test plans as well, which means it will modify the Coverage Guides.
I ran checkbox-cli expand com.canonical.certification::client-cert-desktop-24-04 -f json | jq to get a view of the 24.04 test plan before and after applying the patch:
and indeed, all the jobs mentioned here get their certification-status changed.
@zongminl are we OK with this? It may have an impact on 24.04 projects and contractual requirements...
Hi @pieqq Thanks for the feedback.
|
|
Just to add to Clair's comment, the "fill blocker/non-blocker settings dynamically" part could look something like this: Instead of We could have or flip it: if the current code name is not included in |
|
The feature would be quite complicated to implement and have a consistent semantic about, so my vote is on no. |
0ab0e2d to
0799979
Compare
@Hook25
|
pieqq
left a comment
There was a problem hiding this comment.
For the sake of testing, I ran client-cert-desktop-26-04-automated after removing the certification_status_overrides section, selected a bunch of jobs that have had their certification status overridden to "blocker", and I got this:
submission_2026-04-24T13.12.10.561875.html
So the blocker override works for me even when it's not set at the top-level.
Therefore, I think you can remove them at top-level sections, but keep them in the smaller nested parts.
See my comments below.
| certification_status_overrides: | ||
| apply blocker to com.canonical.certification::audio/detect_sinks | ||
| apply blocker to com.canonical.certification::audio/detect_sources | ||
| apply blocker to com.canonical.certification::audio/alsa_record_playback_automated | ||
| apply blocker to com.canonical.certification::after-suspend-audio/detect_sinks | ||
| apply blocker to com.canonical.certification::after-suspend-audio/detect_sources | ||
| apply blocker to com.canonical.certification::after-suspend-audio/alsa_record_playback_automated | ||
| apply non-blocker to com.canonical.certification::bluetooth4/beacon_eddystone_url_.* | ||
| apply non-blocker to com.canonical.certification::after-suspend-bluetooth4/beacon_eddystone_url_.* | ||
| apply blocker to com.canonical.certification::graphics/1_vkcube_.* | ||
| apply blocker to com.canonical.certification::graphics/2_vkcube_.* | ||
| apply blocker to com.canonical.certification::graphics/vulkaninfo.* | ||
| apply blocker to com.canonical.certification::suspend/validate_suspend_status | ||
| apply blocker to com.canonical.certification::usb/storage-detect | ||
| apply blocker to com.canonical.certification::usb/storage-preinserted-.* | ||
| apply blocker to com.canonical.certification::after-suspend-usb/storage-detect | ||
| apply blocker to com.canonical.certification::after-suspend-usb/storage-preinserted-.* | ||
| apply blocker to com.canonical.certification::wireless/detect | ||
| apply blocker to com.canonical.certification::wwan/detect | ||
| apply blocker to com.canonical.certification::wwan/check-sim-present-manufacturer-model-hw_id-auto | ||
| apply blocker to com.canonical.certification::wwan/gsm-reconnection-.*-auto | ||
| apply blocker to com.canonical.certification::after-suspend-wwan/detect | ||
| apply blocker to com.canonical.certification::after-suspend-wwan/check-sim-present-manufacturer-model-hw_id-auto | ||
| apply blocker to com.canonical.certification::after-suspend-wwan/gsm-reconnection-.*-auto |
There was a problem hiding this comment.
As I've explained in #2479 (comment), I've ran checkbox-cli expand --format json on this test plan with and without this section, and I get the same result.
When using list-bootstrapped, it's a bit more complicated to parse, but I basically get the same thing (at least, the few jobs I checked all had blocker for the certification status).
So I don't think this is needed.
| certification_status_overrides: | ||
| apply blocker to com.canonical.certification::warm-boot-loop-.* | ||
| apply blocker to com.canonical.certification::cold-boot-loop-.* | ||
| apply blocker to com.canonical.certification::ethernet/iperf3_.* |
There was a problem hiding this comment.
Same as above comment. Probably not needed, unless you can provide some clear steps to reproduce in #2479
| certification_status_overrides: | ||
| apply blocker to com.canonical.certification::audio/channels | ||
| apply blocker to com.canonical.certification::audio/external-linein | ||
| apply blocker to com.canonical.certification::audio/external-lineout | ||
| apply blocker to com.canonical.certification::after-suspend-audio/channels | ||
| apply blocker to com.canonical.certification::after-suspend-audio/external-linein | ||
| apply blocker to com.canonical.certification::after-suspend-audio/external-lineout | ||
| apply blocker to com.canonical.certification::fingerprint/detect | ||
| apply blocker to com.canonical.certification::fingerprint/enroll | ||
| apply blocker to com.canonical.certification::fingerprint/verify-no-match | ||
| apply blocker to com.canonical.certification::fingerprint/verify-match | ||
| apply blocker to com.canonical.certification::fingerprint/unlock | ||
| apply blocker to com.canonical.certification::fingerprint/delete | ||
| apply blocker to com.canonical.certification::after-suspend-fingerprint/detect | ||
| apply blocker to com.canonical.certification::after-suspend-fingerprint/enroll | ||
| apply blocker to com.canonical.certification::after-suspend-fingerprint/verify-no-match | ||
| apply blocker to com.canonical.certification::after-suspend-fingerprint/verify-match | ||
| apply blocker to com.canonical.certification::after-suspend-fingerprint/unlock | ||
| apply blocker to com.canonical.certification::after-suspend-fingerprint/delete | ||
| apply blocker to com.canonical.certification::graphics/1_cycle_resolution_.* | ||
| apply blocker to com.canonical.certification::graphics/2_cycle_resolution_.* | ||
| apply blocker to com.canonical.certification::after-suspend-graphics/1_cycle_resolution_.* | ||
| apply blocker to com.canonical.certification::after-suspend-graphics/2_cycle_resolution_.* | ||
| apply blocker to com.canonical.certification::keys/fn-lock | ||
| apply blocker to com.canonical.certification::keys/power-button-suspend | ||
| apply blocker to com.canonical.certification::keys/sleep | ||
| apply blocker to com.canonical.certification::after-suspend-keys/fn-lock | ||
| apply blocker to com.canonical.certification::led/fn | ||
| apply blocker to com.canonical.certification::after-suspend-led/fn | ||
| apply blocker to com.canonical.certification::power-management/light_sensor | ||
| apply blocker to com.canonical.certification::monitor/1_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::audio/1_playback_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::monitor/2_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::audio/2_playback_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::thunderbolt3/daisy-chain | ||
| apply blocker to com.canonical.certification::after-suspend-power-management/light_sensor | ||
| apply blocker to com.canonical.certification::after-suspend-monitor/1_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::after-suspend-audio/1_playback_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::after-suspend-monitor/2_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::after-suspend-audio/2_playback_thunderbolt3_.* | ||
| apply blocker to com.canonical.certification::after-suspend-thunderbolt3/daisy-chain | ||
| apply blocker to com.canonical.certification::touchpad/palm-rejection | ||
| apply blocker to com.canonical.certification::after-suspend-touchpad/palm-rejection | ||
| apply blocker to com.canonical.certification::touchscreen/multitouch-rotate | ||
| apply blocker to com.canonical.certification::after-suspend-touchscreen/multitouch-rotate | ||
| apply blocker to com.canonical.certification::usb-c/c-to-ethernet-adapter-insert | ||
| apply blocker to com.canonical.certification::after-suspend-usb-c/c-to-ethernet-adapter-insert |
There was a problem hiding this comment.
See my comment below, but I don't think this is needed, unless you can provide a way to reproduce in #2479.
There was a problem hiding this comment.
See my comment below, but I don't think this is needed, unless you can provide a way to reproduce in #2479.
"Hi @pieqq,
I've updated the PR to remove the overrides from the top-level 26.04.pxu.
Interestingly, I encountered a blocking behavior in my previous test where the feature test plan overrides didn't seem to be applied by the top plan.
I re-verified the test in a clean environment that the overrides in the feature test plan are working as expected without adding override in the top level test plan.
I've removed the redundant code. Please help to review again. Thanks!
Description
WARNING: This modifies com.canonical.certification::sru-server
Promoted to Focused Stability (Non-Blocker to Blocker-Ready):
These features have reached a stable state with broader DUT (Device Under Test) support. We are transitioning our primary focus toward these areas to ensure full compliance and reliability.
Downgraded Priority:
Based on current SIG certification scopes, Eddystone is no longer a required certification item. Its priority has been lowered to Non-Blocker to optimize our testing bandwidth
Resolved issues
Documentation
Tests
26_Auto_submission.html
26_Manual_submission.html
26_Stress_submission.html