Move custom frontend and load all for all jobs (bugfix)#2457
Open
Move custom frontend and load all for all jobs (bugfix)#2457
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2457 +/- ##
==========================================
+ Coverage 58.87% 58.90% +0.03%
==========================================
Files 476 478 +2
Lines 48004 48042 +38
Branches 8568 8580 +12
==========================================
+ Hits 28260 28298 +38
Misses 18853 18853
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Previous implementation only loaded envvars per provider, effectively binding them to the providers they target. This was a mistake, as that means that providers can't rely on each other and resources like executables are basically useless with this new thing.
874f021 to
10d4be4
Compare
Collaborator
|
Was looking at the documentation, https://github.com/canonical/checkbox/blob/main/docs/how-to/custom-frontend-envvars.rst. You might want to rephrase "accessed globally by all tests in a frontend" with "accessed globally by all tests in a frontend regardless of which provider the test comes from". Or simple "accessed globally by all tests." Testing now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous implementation only loaded envvars per provider, effectively binding them to the providers they target. This was a mistake, as that means that providers can't rely on each other and resources like executables are basically useless with this new architecture.
This adresses this flaw by making all custom frontend variables apply to all jobs, as they should.
Resolved issues
N/A
Documentation
N/A
Tests
Added/moved tests to the new module.
Tested this locally by building checkbox24 and a custom-frontend provider. Snap trying both. Creating a new executable (touch a; chmod +x a) in the custom frontend
/usr/bin, adding the following job to Checkbox to a random pxu and triggering it, it works.Command: