Skip to content

Show skip reason on unsupported remote tests like local (bugfix) #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hook25 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Show skip reason on unsupported remote tests like local (bugfix) #2462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions checkbox-ng/checkbox_ng/launcher/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ def red_text(text, end="\n"):
def black_text(text, end="\n"):
print(SimpleUI.C.BLACK(text), end=end, file=sys.stdout)

def yellow_text(text, end="\n"):
print(SimpleUI.C.YELLOW(text), end=end, file=sys.stderr)

def horiz_line():
print(SimpleUI.C.WHITE("-" * 80))

Expand Down Expand Up @@ -902,9 +905,17 @@ def wait_for_job(self, dont_finish=False, suppress_output=False):
self.finish_job()
break

def finish_job(self, result=None):
def finish_job(self, result=None, job_state=None):
_logger.info("controller: Finishing job with a result: %s", result)
job_result = self.sa.finish_job(result)
if (
job_state
and result
and result.outcome == IJobResult.OUTCOME_NOT_SUPPORTED
):
print(_("Job cannot be started because:"))
for inhibitor in job_state.readiness_inhibitor_list:
SimpleUI.yellow_text(" - {}".format(inhibitor))
SimpleUI.horiz_line()
print(_("Outcome") + ": " + SimpleUI.C.result(job_result))

Expand Down Expand Up @@ -1097,7 +1108,8 @@ def _run_interactable_jobs(self, jobs_repr, total_num=0):
break
else:
self.finish_job(
interaction.extra._builder.get_result()
interaction.extra._builder.get_result(),
job_state,
)
next_job = True
break
Expand Down
Loading