Conversation
This is a weird behaviour because regardless of what the user picks from the ctrl+c menu, we will always re-connect from scratch and sometimes mess up the session
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2463 +/- ##
=======================================
Coverage 58.86% 58.87%
=======================================
Files 476 476
Lines 48007 48002 -5
Branches 8570 8568 -2
=======================================
Hits 28260 28260
+ Misses 18855 18851 -4
+ Partials 892 891 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please add a more detailed description of what the behavior was before this PR, and how this solves the issue. And I was able to continue the execution, disconnect from the agent, and start a new one. |
fernando79513
left a comment
There was a problem hiding this comment.
Thanks for taking care of this.
I think this PR could benefit greatly from some metabox tests. I don't know how difficult it would be to add them, but I think they can help us avoid these kinds of issues in the future.
a6069c1 to
cd38903
Compare
|
I run the metabox tests manually yesterday and they are failing: |
Description
This is a weird behaviour because regardless of what the user picks from the ctrl+c menu, we will always re-connect from scratch and sometimes mess up the session
Resolved issues
N/A (Ctrl+C didnt work, with this patch it does)
Documentation
N/A
Tests
Tested locally, before this patch, Ctrl+C always reconnects, so it basically never works.