VRR capable monitor detection (New)#2465
Draft
tomli380576 wants to merge 4 commits intomainfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
==========================================
- Coverage 58.86% 58.80% -0.07%
==========================================
Files 476 477 +1
Lines 48007 48060 +53
Branches 8570 8581 +11
==========================================
Hits 28260 28260
- Misses 18855 18908 +53
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a script that can detect whether the DUT is connected to any VRR capable monitors. This is supposed to act as the resource job for
graphics/variable-refresh-rate-manualwhenhas_vrris set to true. See #2464 for more context. #2464 and this PR can be merged in any order, they don't reference each other yet. There will be 1 last PR after this one is merged to put everything together.Resolved issues
#2464 as it is right now doesn't actually check whether the DUT is connected to a VRR capable monitor.
Documentation
The basic idea is to mimic what
modetest -connectorsdoes (this command comes from libdrm-tests).modetestwill print these lines for a VRR capable monitor:If VRR is impossible, this property is either 0 or missing altogether. This script uses the same libdrm API calls to find this value.
The exact lines we are mimicking
Tests
Manually checked the output of this script against GNOME's output in gnome settings.