Fix regex in benchmarks cpu/disk_on_idle (BugFix)#2487
Fix regex in benchmarks cpu/disk_on_idle (BugFix)#2487
Conversation
* for disk_on_idle and cpu_on_idle, fix regex to resolve warning about invalid escape char in newer python3 versions. (older Python3 just silently passed it) * Also added CLAUDE.md to gitignore to avoid accidentally pulling in Claude instructions when making commits. Fixes #2477
There was a problem hiding this comment.
Pull request overview
Fixes Python SyntaxWarning noise in benchmark jobs by making the regex patterns raw strings (so \S is treated as a regex escape rather than an invalid Python string escape), and prevents accidental commits of local Claude instruction files.
Changes:
- Update
benchmarks/system/cpu_on_idleandbenchmarks/system/disk_on_idlecommands to use raw-string regex patterns inre.findall(...). - Add
CLAUDE.mdto.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
providers/base/units/benchmarks/jobs.pxu |
Uses raw-string regex literals in two benchmark job commands to eliminate invalid-escape warnings on newer Python versions. |
.gitignore |
Ignores CLAUDE.md to avoid committing local tooling instructions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
+ Coverage 58.91% 58.93% +0.01%
==========================================
Files 476 477 +1
Lines 48011 48034 +23
Branches 8569 8571 +2
==========================================
+ Hits 28286 28309 +23
+ Misses 18833 18830 -3
- Partials 892 895 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…pt, add unit tests, and update the job descriptions accordingly
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Resolved issues
Resolves #2477
Resolves CHECKBOX-2238
Documentation
NA
Tests
Tested on a fresh Bionic install to verify rawstrings does work back that far:
For comparison, this is Resolute where the initial warnings appeared for me, showing before and after: