Fix: Add validations to suspend_trigger (BugFix)#2500
Open
EstebanVg15 wants to merge 2 commits intocanonical:mainfrom
Open
Fix: Add validations to suspend_trigger (BugFix)#2500EstebanVg15 wants to merge 2 commits intocanonical:mainfrom
EstebanVg15 wants to merge 2 commits intocanonical:mainfrom
Conversation
8053763 to
da7085e
Compare
1734983 to
bda469a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
+ Coverage 58.92% 58.93% +0.01%
==========================================
Files 476 476
Lines 48031 48043 +12
Branches 8574 8576 +2
==========================================
+ Hits 28303 28315 +12
Misses 18835 18835
Partials 893 893
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bda469a to
708f6cb
Compare
* Run "systemctl list-jobs suspend" to check if there are suspend jobs running before running one more. * If "systemctl list-jobs suspend" detects suspend jobs running wait for a while before proceeding. * Set "set -o pipefail" on the Checkbox job definition for the job to be marked as "failed" when exiting on error.
7972510 to
3e3604f
Compare
a8028f1 to
dfa9d20
Compare
* Include fixes for the unit tests to succeed with the new systemctl callbacks.
dfa9d20 to
427dd93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following jobs were executed as part of the NVIDIA Riverside Stress test plans.
As can be seen the following error is commonly displayed.
Even though the suspend command failed, the job is marked as
Outcome: job passed, and the error is printed cyclically in further iterations.This PR proposes some validations for the
suspend_trigger.pyscript to make thestress-tests/suspend_cycles_{{suspend_id}}_reboot{{suspend_reboot_id}}test cases more robust.systemctl list-jobs *suspend*to check if there are suspend jobs running before running one more.systemctl list-jobs *suspend*detects suspend jobs running, the job will wait before proceeding.set -o pipefailon the Checkbox job definition for the job to be marked as "failed" when exiting on error.systemctl list-jobs *suspend*calls.Resolved issues
https://warthogs.atlassian.net/browse/PERI-1367
Documentation
Tests
I ran the
com.canonical.certification::suspend-cycles-stress-testtest plan two times on anvidia-jetson-orin-nanoDUT.stress-tests/suspend_cycles_29_reboot3there where suspend jobs still on-going when trying to suspend the device once more, but the test case waited until being able to send the corresponding commands.