Skip to content

chore(22.04): add pkg-deps job#188

Merged
cjdcordeiro merged 1 commit intocanonical:ubuntu-22.04from
rebornplusplus:ci/22.04/pkg-deps
Mar 13, 2024
Merged

chore(22.04): add pkg-deps job#188
cjdcordeiro merged 1 commit intocanonical:ubuntu-22.04from
rebornplusplus:ci/22.04/pkg-deps

Conversation

@rebornplusplus
Copy link
Copy Markdown

Proposed changes

This PR adds a new pkg-deps job on Pull Request. It checks in changed files if slices of any package A has been listed in "essential" of a slice in package B, but B does not depend on A. If found, the CI will add a comment in the Pull Request with the findings.

Related issues/PRs

#187

Testing

See demo at rebornplusplus#9.

Checklist

This commit adds a new pkg-deps job on Pull Request. It checks in
changed files if slices of any package A has been listed in "essential"
of a slice in package B, but B does not depend on A. If found, the CI
will add a comment in the Pull Request with the findings.
@cjdcordeiro cjdcordeiro added the Priority Look at me first label Mar 12, 2024
@cjdcordeiro cjdcordeiro self-assigned this Mar 13, 2024
Copy link
Copy Markdown
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple.

Copy link
Copy Markdown

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjdcordeiro cjdcordeiro merged commit ffa21b5 into canonical:ubuntu-22.04 Mar 13, 2024
@cjdcordeiro
Copy link
Copy Markdown
Collaborator

@rebornplusplus pls create the PRs for the remaining branches

gregory-schiano pushed a commit to gregory-schiano/chisel-releases that referenced this pull request Jun 22, 2024
This commit adds a new pkg-deps job on Pull Request. It checks in
changed files if slices of any package A has been listed in "essential"
of a slice in package B, but B does not depend on A. If found, the CI
will add a comment in the Pull Request with the findings.
cjdcordeiro pushed a commit to ozanvos/chisel-releases that referenced this pull request Sep 27, 2024
This commit adds a new pkg-deps job on Pull Request. It checks in
changed files if slices of any package A has been listed in "essential"
of a slice in package B, but B does not depend on A. If found, the CI
will add a comment in the Pull Request with the findings.
NWarila pushed a commit to nwarila-platform/chisel-releases that referenced this pull request Apr 24, 2026
This commit adds a new pkg-deps job on Pull Request. It checks in
changed files if slices of any package A has been listed in "essential"
of a slice in package B, but B does not depend on A. If found, the CI
will add a comment in the Pull Request with the findings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority Look at me first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants