fix: build cilium-envoy proxylib with go 1.25-fips for proxy v1.34#58
Merged
Merged
Conversation
cilium/proxy v1.34's go.mod requires Go >= 1.25.0. These rocks install go/1.24-fips/stable to match the upstream Cilium builder, but FIPS Go pins GOTOOLCHAIN=local so it will not auto-fetch a newer toolchain the way the non-FIPS snap does. The proxylib build (libcilium.so) therefore fails with: go: ../go.mod requires go >= 1.25.0 (running go 1.24.13; GOTOOLCHAIN=local) Refresh the global go snap to 1.25-fips for the cilium-envoy part only, right before 'make -C proxylib all'. Each later go-using part already re-refreshes to 1.24-fips itself, so the agent and other components are unaffected. 1.17.1 (proxy v1.31) and the non-FIPS static variants build fine and are intentionally left untouched.
canonical-berkayoz
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cilium-envoyproxylib build failure for the1.17.9,1.17.12, and1.18.4cilium rocks, which broke the post-merge Push Multiarch Images run for Add Cilium 1.19.4 rocks #57 and prevented the1.19.4-ck0manifest from publishing.cilium/proxysource-tag: v1.34, whosego.modrequires Go>= 1.25.0, but they installgo/1.24-fips/stableto match the upstream Cilium builder.GOTOOLCHAIN=local, so unlike the non-FIPS snap it will not auto-fetch a newer toolchain, producing:Fix
snap refresh go --channel 1.25-fips/stableto thecilium-envoypart only, immediately beforemake -C proxylib all.snap refresh go --channel 1.24-fips/stable, so the agent and all other components remain on Go 1.24-fips (matching the upstream builder). The change is self-contained to the envoy proxylib build.Scope / intentionally untouched
1.17.1uses proxyv1.31(go.mod ≤ 1.24) — unaffected.staticvariants usego/1.24/stable, which auto-downloads 1.25 — unaffected.1.19.4already installsgo/1.25-fips/stableglobally — used as the reference for this fix.Validation
cilium-envoyoverride-build.snap refresh gopattern already used throughout these files.