ci: pin rockcraft to latest/candidate channel for all versions#59
Merged
Conversation
Replace the repo-wide rockcraft revision pin (3494/3547) with a per-version .rockcraft-version.yaml selecting the latest/edge channel. The build workflow's rockcraft resolution only walks the rock dir and its immediate parent, so the repo-root .rockcraft-version.yaml was never consulted for nested rocks; those fell through to the rockcraft-revisions workflow input. Placing the file at each X.Y.Z/ dir makes the channel selection effective. The latest/edge rockcraft is expected to resolve the FIPS libgcrypt20 apt-downgrade failure in the 1.16.3 build. The 1.17.12 static variants keep their latest/stable + pro-features: disabled overrides.
The build workflow's PR change-detection keys off hashFiles(rockPath/**) and the **/rockcraft.yaml path filter. The parent-level X.Y.Z/ .rockcraft-version.yaml files were outside each rock dir, so they changed neither signal and every rock was treated as unchanged -- build-rocks, run-tests and the multiarch manifest were all skipped. Move the latest/edge selection into each rock directory (next to rockcraft.yaml -- the workflow's documented priority-1 location). This changes each rock's content hash so the rocks are rebuilt and validated, and keeps channel resolution correct. The 1.17.12 static variants keep their own latest/stable + pro-features: disabled overrides.
Switch the non-static .rockcraft-version.yaml files from latest/edge to latest/candidate. The static 1.17.12 variants keep latest/stable + pro-features: disabled.
ktsakalozos-canonical
changed the title
Contributor
Author
|
Depends on canonical/k8s-workflows#60 |
latest/stable is the build_rocks workflow default, so per-rock files that only set that channel are unnecessary. Static variants keep their pro-features: disabled overrides.
The debug-wrapper part installed `dlv@latest`, which now resolves to delve v1.27.0 requiring Go >= 1.25. Rocks built with go/1.24-fips fail with GOTOOLCHAIN=local. Pin to v1.26.3, the latest delve release that still supports Go 1.24 (and is forward-compatible with Go 1.25).
The debug-wrapper part installed `dlv@latest`, which now resolves to delve v1.27.0 requiring Go >= 1.25. Rocks built with go/1.24-fips fail with GOTOOLCHAIN=local. Pin to v1.26.3, the latest delve release that still supports Go 1.24 (and is forward-compatible with Go 1.25).
This was referenced Jul 2, 2026
canonical-berkayoz
approved these changes
Jul 3, 2026
HomayoonAlimohammadi
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3494/3547) with a per-version, per-rockX.Y.Z/<rock>/.rockcraft-version.yamlselecting thelatest/candidatechannel for all 9 versions..rockcraft-version.yamland therockcraft-revisionsinput inpull_request.yaml.Why
The shared build workflow's rockcraft resolution only walks the rock directory and its immediate parent, so the repo-root
.rockcraft-version.yamlwas never consulted for nested rocks — they silently fell through to therockcraft-revisionsworkflow input. Placing the file in each rock directory makes the channel selection effective.The pinned rockcraft revision was producing a deterministic FIPS build failure in the
1.16.3build:(FIPS overlay wanting the FIPS-certified, lower-versioned
libgcrypt20vs the newer noble-archive version). Moving tolatest/candidateis expected to pick up newer rockcraft handling of the FIPS apt-overlay and resolve this.Notes
1.17.12staticvariants keep their existinglatest/stable+pro-features: disabledoverrides (unchanged).pro-featureskey is set in the new files, so they inheritfips-updatesfrom the workflow.