feat(growpart): add LVM resize support #6586
Conversation
Fixes canonicalGH-3265 This change integrates LVM logical volume resizing into the existing growpart flow. When the target block device is an LVM LV, cloud-init now performs: - lvs lookup to determine the volume group - enumeration of PVs in the VG - pvresize on each PV - lvextend +100%FREE on the LV Filesystem resizing is intentionally omitted because resizefs is handled by a separate module. Unit tests have been added under test_cc_growpart.py to validate: - successful pvresize and lvextend calls - error propagation for failed operations This change does not affect existing non-LVM growpart behaviour. Signed-off-by: Amy Chen <[email protected]>
xiachen-rh
force-pushed
the
growpart-lvm-resize
branch
from
edda542 to
6f2082b
Compare
|
I think there should be a configuration switch to control whether or not the LV is resized (the PV resize seems fine) - often when LVM is used there will be multiple LVs (i.e. for /home, for /var/log, etc) and so having the LV for rootfs ("/") be grown to use up the whole of the VG is likely to be undesirable. Also the growpart script (from cloud-utils) has some pvresize functionality (I forget any issues with it) and so it doesn't make sense to have LVM functionality in both cloud-util's growpart and in cloud-init's growpart module. |
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.) |
github-actions
bot
added
the
stale-pr
|
@dermotbradley thanks a lot for your comment, let me check how to update the code. |
|
Hello @blackboxsw could you help me re-open it please? I will continue working on it. |
github-actions
bot
removed
the
stale-pr
3 participants
Fixes GH-3265
This change integrates LVM logical volume resizing into the existing growpart flow. When the target block device is an LVM LV, cloud-init now performs:
Filesystem resizing is intentionally omitted because resizefs is handled by a separate module.
Unit tests have been added under test_cc_growpart.py to validate:
This change does not affect existing non-LVM growpart behaviour.
Redhat Jira ticket: [RFE][Azure]growpart fails to resize a root partition on LVM
https://issues.redhat.com/browse/RHEL-107485
Test Steps
I tested it on Azure and AWS with rhel image, for example,
Boot up a VM on Azure and change the os disk to bigger than 64G
Check the rootlv partition size, the root partition size is extended after VM boot up.
[Before changes]
The root partition size is not extended.
[After changes]
The root partition size is extended.
I’ve added three unit tests. Please let me know if further coverage is needed.
The integration test case is copied from #887, however I did not test it because that I failed to set up the local integration test environment, I will run it later.