feat(subp): Support subprocess user and group credentials - #7010
Draft
cgroschupp wants to merge 1 commit into
Draft
feat(subp): Support subprocess user and group credentials#7010cgroschupp wants to merge 1 commit into
cgroschupp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
fix(opennebula): avoid sudo when parsing context.sh
OpenNebula parses context.sh as the configured parse user. Previously
this was done by spawning sudo -u, which can block during early boot and
cause cloud-init-local.service to wait for the sudo timeout.
Resolve the parse user with pwd.getpwnam and pass the target uid, gid,
and empty supplemental groups directly through subp.subp to
subprocess.Popen. This preserves the existing sh-based parser while
avoiding sudo during datasource detection.
Add unit coverage for the new subp uid/gid passthrough and for the
OpenNebula parser invocation.
Fixes GH-4078
LP: #2007149
Checkboxes you can mark based on your state:
tests/unittests/