fix(cloudstack): avoid UnboundLocalError for primary_nic on NoDHCPLeaseError - #7031
Open
sundeep8967 wants to merge 1 commit into
Open
fix(cloudstack): avoid UnboundLocalError for primary_nic on NoDHCPLeaseError#7031sundeep8967 wants to merge 1 commit into
sundeep8967 wants to merge 1 commit into
Conversation
When perform_dhcp_setup is False, primary_nic was unassigned when get_vr_address raised NoDHCPLeaseError, causing an unhandled UnboundLocalError when logging. Initialize primary_nic to None. Fixes canonicalGH-6838
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
DataSourceCloudStack._get_data, whenself.perform_dhcp_setupisFalse,primary_nicis never assigned. Ifget_vr_address(self.distro)subsequently raises aNoDHCPLeaseError, the exception handler attempts to log:which crashes with:
Solution
primary_nic = Nonebefore the DHCP setup branch inDataSourceCloudStack._get_data.test_get_data_no_dhcp_lease_error_without_dhcp_setupundertests/unittests/sources/test_cloudstack.pyto verify thatNoDHCPLeaseErrorwithperform_dhcp_setup=Falselogs cleanly and returnsFalsewithout raising anUnboundLocalError.Fixes #6838
Testing
UnboundLocalErrorreproduced).tests/unittests/sources/test_cloudstack.pypass with 100% success after the fix.