feat: Merge user provided bootstrap config with the generated one #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HomayoonAlimohammadi
force-pushed
the
KU-4167/bootstrap-config-loss
branch
2 times, most recently
from
0c00f11 to
81d0643
Compare
Signed-off-by: Homayoon (Hue) Alimohammadi <[email protected]>
HomayoonAlimohammadi
force-pushed
the
KU-4167/bootstrap-config-loss
branch
from
21ac793 to
cecf06c
Compare
Signed-off-by: Homayoon (Hue) Alimohammadi <[email protected]>
Signed-off-by: Homayoon (Hue) Alimohammadi <[email protected]>
HomayoonAlimohammadi
force-pushed
the
KU-4167/bootstrap-config-loss
branch
from
2fc82c6 to
1be8570
Compare
|
Marking as draft to be investigated later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes:
This PR merges the user provided bootstrap config with the generated one. This way the user is not required to provide the whole bootstrap config.
The proposed behavior is to merge maps replace slices according to how
yaml.Unmarshalhandles duplicate entries. The unit tests aim to verify the expected behavior.