feat: Cordon and drain the node before removing from the cluster #185
+723
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HomayoonAlimohammadi
force-pushed
the
KU-4386/drain-node-on-removal
branch
2 times, most recently
from
45bbfdc to
9a99094
Compare
Signed-off-by: Homayoon (Hue) Alimohammadi <[email protected]>
HomayoonAlimohammadi
force-pushed
the
KU-4386/drain-node-on-removal
branch
from
076c257 to
de306df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR will cordon and drain the node that is to be deleted (during a scaledown, etc.)
If a failure occurs, the node is uncordoned to prevent having unschedulable nodes that are not going to be deleted.
The draining process is retried until there's no other pod on the node that can be evicted/deleted.
Note that we can not retry pod eviction through retriggering the reconciliation, since each time a new machine can be selected for deletion.