feat(bases): make BaseName compatible with craft-platforms#723
Draft
feat(bases): make BaseName compatible with craft-platforms#723
Conversation
These are far from complete for craft-providers.
This adds two convenience methods to BaseName to make it compatible with craft-platforms DistroBase and marks the DistroBase as deprecated in favour of the craft-platforms DistroBase. It also updates functions that take a BaseName to take a DistroBase as well. This does not set a schedule for when BaseName will be removed. Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
lengau
force-pushed
the
work/craft-platforms
branch
from
bbec9ff to
94e5d6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox?This adds two convenience methods to BaseName to make it compatible
with craft-platforms DistroBase and marks the DistroBase as deprecated
in favour of the craft-platforms DistroBase.
It also updates functions that take a BaseName to take a DistroBase
as well.
This does not set a schedule for when BaseName will be removed.