Skip to content

[WD-21922] chore: clean up nested routes #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented May 5, 2025

Done

  • Clean up routes
  • Proper nesting of sub-routes
  • Extract routes function

QA

QA steps

  • Checkout this branch
  • Run the project
docker run -d -p 5432:5432 -e POSTGRES_PASSWORD=postgres postgre
source .venv/bin/activate
set -a
source .env
source .env.local
set +a
flask --app webapp.app run --debug

Run in a separate terminal:

yarn dev
  • Try selecting different pages and verify the routing works as expected

Fixes

@webteam-app
Copy link

@muhammad-ali-pk muhammad-ali-pk changed the title [WD-21922] chore: clean up routes [WD-21922] chore: clean up nested routes May 5, 2025
Base automatically changed from feat-views to main May 6, 2025 07:53
Copy link
Member

@samhotep samhotep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants