Skip to content

Conversation

@gabrielcocenza
Copy link
Member

@gabrielcocenza gabrielcocenza commented Sep 13, 2024

dcgmproftester has diffetent versions and needs libcuda which is not currently shipped in the snap, so it does not work out of the box. Moreover, some versions like the dcgmproftester10 is not present in the arm64 version that breaks the build.

This PR removes all dcgmproftester and libs that needs cuda until we have a more clear way on how to ship this service and keep the support for multi-arch

Closes: #18

`dcgmproftester` has diffetent versions and needs libcuda which is
not currently shipped in the snap, so it does not work out of the
box. Moreover, some versions like the `dcgmproftester10` is not
present in the arm64 version that breaks the build.

This PR removes all dcgmproftester until we have a more clear way
on how to ship this service and keep the support for multi-arch

Closes: canonical#18
@gabrielcocenza
Copy link
Member Author

Just to complement here are the logs proving that removing the dcgmproftester will make the build work for arm64:

2024-09-13 15:23:11.269 :: 2024-09-13 15:17:41.824 - library: libnvml_injection.so.1: unused library 'usr/lib/aarch64-linux-gnu/libnvml_injection.so.1.0'. (https://snapcraft.io/docs/linters-library)     
2024-09-13 15:23:11.271 :: 2024-09-13 15:17:41.826 - library: libnvperf_host.so: unused library 'usr/lib/aarch64-linux-gnu/libnvperf_dcgm_host.so'. (https://snapcraft.io/docs/linters-library)            
2024-09-13 15:23:11.272 :: 2024-09-13 15:17:41.829 pack_snap: output='.', compression='xz'                                                                                                                 
2024-09-13 15:23:11.274 :: 2024-09-13 15:17:41.832 pack_snap: check skeleton                                                                                                                               
2024-09-13 15:23:11.276 :: 2024-09-13 15:17:42.297 Creating snap package...                                                                                                                                
2024-09-13 15:23:11.277 :: 2024-09-13 15:17:42.301 Pack command: ['snap', 'pack', '--filename', 'dcgm_3.3.7_arm64.snap', '--compression', 'xz', PosixPath('/root/prime'), PosixPath('/root/project')]      
2024-09-13 15:23:11.279 :: 2024-09-13 15:23:03.007 Packed dcgm_3.3.7_arm64.snap                                                                                                                            
2024-09-13 15:23:11.291 Executing on host: lxc --project snapcraft config device show local:snapcraft-dcgm-on-arm64-for-arm64-259410                                                                       
2024-09-13 15:23:12.647 Executing on host: lxc --project snapcraft config device remove local:snapcraft-dcgm-on-arm64-for-arm64-259410 disk-/root/project                                                  
2024-09-13 15:23:14.507 Executing on host: lxc --project snapcraft stop local:snapcraft-dcgm-on-arm64-for-arm64-259410 

Currently, the build is failing

Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also remove the executables and related libraries? They are the greatest contributors to the size of the snap so we have a chance to trim a lot of MBs. See #2

Also please update the description in snapcraft.yaml to mention the absence of these tools as we are diverging from upstream. Of course we have the main documentation PR pending, so a quick sentence is enough to ensure we don't forget.

- remove cudas libs not used
@gabrielcocenza
Copy link
Member Author

Snap package now is only 25M compared to 800M that was before this change

samuelallan72
samuelallan72 previously approved these changes Sep 16, 2024
aieri
aieri previously approved these changes Sep 16, 2024
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, with some minor suggestions

@gabrielcocenza gabrielcocenza merged commit 0f17eee into canonical:main Sep 17, 2024
3 checks passed
@gabrielcocenza gabrielcocenza deleted the remove-dcgmproftester branch September 17, 2024 01:24
@Deezzir Deezzir mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ARM64 cannot build because it does not have dcgmproftester10

3 participants