-
Notifications
You must be signed in to change notification settings - Fork 4
Remove all dcgmproftester #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all dcgmproftester #19
Conversation
`dcgmproftester` has diffetent versions and needs libcuda which is not currently shipped in the snap, so it does not work out of the box. Moreover, some versions like the `dcgmproftester10` is not present in the arm64 version that breaks the build. This PR removes all dcgmproftester until we have a more clear way on how to ship this service and keep the support for multi-arch Closes: canonical#18
|
Just to complement here are the logs proving that removing the Currently, the build is failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also remove the executables and related libraries? They are the greatest contributors to the size of the snap so we have a chance to trim a lot of MBs. See #2
Also please update the description in snapcraft.yaml to mention the absence of these tools as we are diverging from upstream. Of course we have the main documentation PR pending, so a quick sentence is enough to ensure we don't forget.
- remove cudas libs not used
|
Snap package now is only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, with some minor suggestions
dcgmproftesterhas diffetent versions and needs libcuda which is not currently shipped in the snap, so it does not work out of the box. Moreover, some versions like thedcgmproftester10is not present in the arm64 version that breaks the build.This PR removes all dcgmproftester and libs that needs cuda until we have a more clear way on how to ship this service and keep the support for multi-arch
Closes: #18