-
Notifications
You must be signed in to change notification settings - Fork 4
Separate the snap by cuda version on v4 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- remove dcgmproftester10
snapcraft.yaml.in acts like a template and the right values can be added by running: CUDA_VERSION=13 envsubst '$CUDA_VERSION' < snap/snapcraft.yaml.in > snap/snapcraft.yaml With this kind of approach it's possible to dinamically generate the snap and dependencies to be build
3f29edf to
2c6e691
Compare
2c6e691 to
0c8d5a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but remember to update the documentation in snapcraft.yaml.in once the snap track management and release strategy are defined. I suspect you will need to do more than sudo snap install dcgm e.g. sudo snap install dcgm --channel v4-cuda11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Follow-ups I'd like to see:
- Document the snap track policy.
- Provide a reproducible local snap build—via a Makefile, a tox target, or clear documented steps.
|
@gabrielcocenza I think we will need a special release and promote actions for each track, is it something in the scope of this PR? |
- update documentation
ee6315c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some comments to address, I am concerned about the formatting the most, if you have admin access to the DCGM listing, you can copy/paste to check the final result
- fix doc indententation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
From the transition from v3 to v4, dcgm now separate the debian packages based in the cuda version.
This approach tries to have a single branch to pack and distribute several dcgm snaps based in the cuda version.
snapcraft.yaml.in acts like a template and the right values can be added by running:
With this kind of approach it's possible to dinamically generate the snap and dependencies to be build
#69