Skip to content

Conversation

@gabrielcocenza
Copy link
Member

@gabrielcocenza gabrielcocenza commented Sep 10, 2025

From the transition from v3 to v4, dcgm now separate the debian packages based in the cuda version.

This approach tries to have a single branch to pack and distribute several dcgm snaps based in the cuda version.

snapcraft.yaml.in acts like a template and the right values can be added by running:

 CUDA_VERSION=13 envsubst '$CUDA_VERSION'  < snap/snapcraft.yaml.in > snap/snapcraft.yaml

With this kind of approach it's possible to dinamically generate the snap and dependencies to be build

#69

- remove dcgmproftester10
snapcraft.yaml.in acts like a template and the right values can
be added by running:

CUDA_VERSION=13 envsubst '$CUDA_VERSION'  < snap/snapcraft.yaml.in > snap/snapcraft.yaml

With this kind of approach it's possible to dinamically generate
the snap and dependencies to be build
@gabrielcocenza gabrielcocenza force-pushed the multiple-track branch 2 times, most recently from 3f29edf to 2c6e691 Compare September 16, 2025 19:19
@gabrielcocenza gabrielcocenza mentioned this pull request Sep 16, 2025
@gabrielcocenza gabrielcocenza marked this pull request as ready for review September 16, 2025 21:52
@gabrielcocenza gabrielcocenza requested a review from a team as a code owner September 16, 2025 21:52
chanchiwai-ray
chanchiwai-ray previously approved these changes Sep 17, 2025
Copy link

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but remember to update the documentation in snapcraft.yaml.in once the snap track management and release strategy are defined. I suspect you will need to do more than sudo snap install dcgm e.g. sudo snap install dcgm --channel v4-cuda11

jneo8
jneo8 previously approved these changes Sep 17, 2025
Copy link

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Follow-ups I'd like to see:

  • Document the snap track policy.
  • Provide a reproducible local snap build—via a Makefile, a tox target, or clear documented steps.

@Deezzir
Copy link
Contributor

Deezzir commented Sep 18, 2025

@gabrielcocenza I think we will need a special release and promote actions for each track, is it something in the scope of this PR?

- update documentation
@gabrielcocenza gabrielcocenza dismissed stale reviews from jneo8 and chanchiwai-ray via ee6315c September 19, 2025 14:13
@gabrielcocenza
Copy link
Member Author

@Deezzir I'm waiting for snapcraft team approve the creation of the new tracks.

After they approve, we can touch the release and promotion part

@gabrielcocenza gabrielcocenza changed the title [POC] Separate the snap by cuda version on v4 Separate the snap by cuda version on v4 Sep 19, 2025
chanchiwai-ray
chanchiwai-ray previously approved these changes Sep 23, 2025
chanchiwai-ray
chanchiwai-ray previously approved these changes Sep 25, 2025
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left some comments to address, I am concerned about the formatting the most, if you have admin access to the DCGM listing, you can copy/paste to check the final result

- fix doc indententation
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the comments

Copy link

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@gabrielcocenza gabrielcocenza merged commit 0836bc2 into main Sep 26, 2025
15 checks passed
@gabrielcocenza gabrielcocenza deleted the multiple-track branch September 26, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants