Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAML integration #199

Merged
merged 25 commits into from
Mar 12, 2024
Merged

Add SAML integration #199

merged 25 commits into from
Mar 12, 2024

Conversation

gtrkiller
Copy link
Contributor

Overview

Add SAML integration using the SAML Integrator charm

Rationale

Simplify the charm's logic and modularize SAML interactions.

Juju Events Changes

Module Changes

Library Changes

Add the SAML

Checklist

@gtrkiller gtrkiller requested a review from a team as a code owner March 6, 2024 13:04
@gtrkiller gtrkiller marked this pull request as draft March 6, 2024 13:04
@gtrkiller gtrkiller marked this pull request as ready for review March 11, 2024 14:36
@canonical canonical deleted a comment from github-actions bot Mar 11, 2024
@canonical canonical deleted a comment from github-actions bot Mar 11, 2024
yanksyoon
yanksyoon previously approved these changes Mar 12, 2024
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments! Thanks!

Copy link
Contributor

Test coverage for 83a8089

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        338     35     82     11    89%   186, 194-195, 207-219, 384->389, 588-590, 595-596, 607-609, 614-615, 627-629, 634-635, 647-649, 674-676, 718->exit, 728->exit, 758-764, 790->exit, 804-805, 815->exit, 829
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               368     36     90     12    89%

Static code analysis report

Run started:2024-03-12 15:46:33.687614

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2035
  Total lines skipped (#nosec): 3
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@mthaddon mthaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

Copy link
Collaborator

@weiiwang01 weiiwang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few minor suggestions for future improvement, but overall looks good!

@gtrkiller gtrkiller merged commit cdd64c2 into main Mar 12, 2024
20 checks passed
@gtrkiller gtrkiller deleted the saml_integ branch March 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants