-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SAML integration #199
Add SAML integration #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments! Thanks!
Test coverage for 83a8089
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few minor suggestions for future improvement, but overall looks good!
Overview
Add SAML integration using the SAML Integrator charm
Rationale
Simplify the charm's logic and modularize SAML interactions.
Juju Events Changes
Module Changes
Library Changes
Add the SAML
Checklist
src-docs
urgent
,trivial
,complex
)