Fix Integration tests#63
Merged
Merged
Conversation
- Revert Python version from ~=3.14.2 to >=3.12.2,<3.13 - Python 3.14 doesn't exist yet - Indico requires Python <3.13,>=3.12.2 - Add newline at end of README
srbouffard
requested review from
florentianayuwono and
seb4stien
and removed request for
a team
- Remove obsolete Python 3.10 lxml wheel (project now requires Python 3.12) - Force lxml and xmlsec to build from source in integration test environment - This ensures both packages link against the same system libxml2 version - Fixes: xmlsec.Error: (100, 'lxml & xmlsec libxml2 library version mismatch') The PIP_NO_BINARY setting only affects integration tests in CI. Production installations will still use pre-built wheels which are compatible when installed together.
The previous fix didn't work because poetry doesn't respect PIP_NO_BINARY. Now explicitly installing lxml and xmlsec from source with pip before running poetry install, ensuring they build against system libxml2.
Poetry was downgrading lxml from 6.0.2 (built from source) to 5.3.0 (binary wheel from poetry.lock), causing version mismatch with xmlsec. Now running poetry install first, then force-reinstalling lxml and xmlsec from source with --force-reinstall --no-deps to prevent poetry from interfering.
- Add lxml>=5.0 to pyproject.toml to make the dependency explicit - Update poetry.lock (content-hash only - indico still pins lxml to 5.3.0) - Build lxml==5.3.0 and xmlsec==1.3.17 from source in integration tests - This respects indico's version pin while ensuring both link to same libxml2 - Also add .venv/ to .gitignore
DeeKay3
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes broken integration tests.
Changes:
Remove outdated lxml wheel file targeting and old python version
Update integration test fixtures in conftest.py
Update dependencies in poetry.lock and pyproject.toml due to mismatch in versions for
lxmlandxmlsecUpdate tox.ini configuration
Context: This repo is a Python library (not a charm), so it has no build artifacts. The integration test workflow expects charms/rocks and fails with empty build arrays. The CI will start passing once
operator-workflows branch until Skip integration test build if plan is empty operator-workflows#918 is merged.