Feat/app integration

[yhaliaw]

Applicable spec: ISD-202

Overview

The github-runner-manager service is enabled in the charm now.

Rationale

This allow us to check logs of the service, to monitor if the service is stable.

Checklist

• The charm style guide was applied.
• The contributing guide was applied.
• The changes are compliant with ISD054 - Managing Charm Complexity
• The documentation for charmhub is updated.
• The PR is tagged with appropriate label (urgent, trivial, complex).
• The changelog is updated with changes that affects the users of the charm.

The changelog is not updated, since the usage of service does not impact the users.

[cbartz]

Thank you!

[cbartz]

What about upgrading? How is this handled?

[yhaliaw]

It is a local python package.
Installing it with code changes would update the installation.

The _common_install_code function is called on charm upgrade as well. So it should cover the charm upgrade event.

[cbartz]

So due to the --ignore-installed flag it would just install without caring about a previous installation?

[yhaliaw]

I have updated the install_package method to uninstall the packages prior to installing them.

[cbartz]

Is this test really adding value?

[yhaliaw]

Personally, I think it does not add value right now.
But it does increase the code coverage.

[github-actions]

Test results for commit 57ad4c7

Test coverage for 57ad4c7

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-04-24 06:55:56.575355

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1810
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 2

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

[github-actions]

TICS Quality Gate

✔️ Passed

github-runner-operator

All conditions passed

See the results in the TICS Viewer

The following files have been checked for this project

• github-runner-manager/src/github_runner_manager/errors.py
• github-runner-manager/src/github_runner_manager/github_client.py
• github-runner-manager/src/github_runner_manager/manager/runner_manager.py
• github-runner-manager/src/github_runner_manager/openstack_cloud/openstack_runner_manager.py
• github-runner-manager/src/github_runner_manager/platform/github_provider.py
• github-runner-manager/src/github_runner_manager/platform/jobmanager_provider.py
• github-runner-manager/src/github_runner_manager/platform/multiplexer_provider.py
• github-runner-manager/src/github_runner_manager/platform/platform_provider.py
• github-runner-manager/src/github_runner_manager/reactive/consumer.py
• github-runner-manager/src/github_runner_manager/types_/github.py
• github-runner-manager/tests/unit/mock_runner_managers.py
• github-runner-manager/tests/unit/openstack_cloud/test_openstack_runner_manager.py
• github-runner-manager/tests/unit/test_github_client.py
• src/charm.py
• src/errors.py
• src/manager_service.py
• tests/integration/test_charm_no_runner.py
• tests/integration/test_jobmanager.py
• tests/unit/conftest.py
• tests/unit/test_charm.py
• tests/unit/test_factories.py
• tests/unit/test_manager_service.py

.github/workflows/tics.yaml / TICS / TICS GitHub Action