Skip to content

Feat/app integration #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 29, 2025
Merged

Feat/app integration #530

merged 24 commits into from
Apr 29, 2025

Conversation

yhaliaw
Copy link
Collaborator

@yhaliaw yhaliaw commented Apr 17, 2025

Applicable spec: ISD-202

Overview

The github-runner-manager service is enabled in the charm now.

Rationale

This allow us to check logs of the service, to monitor if the service is stable.

Checklist

The changelog is not updated, since the usage of service does not impact the users.

@yhaliaw yhaliaw marked this pull request as ready for review April 22, 2025 04:51
Copy link
Collaborator

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yhaliaw yhaliaw requested review from cbartz April 25, 2025 01:37
yhaliaw added 2 commits April 28, 2025 15:55
This reverts commit 4eb1a04.
This reverts commit 8c46fd4.
Copy link
Contributor

Test results for commit 08acf8b

Test coverage for 08acf8b

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-04-29 02:00:36.332925

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1818
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 2

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yhaliaw yhaliaw merged commit e4e0901 into main Apr 29, 2025
54 of 56 checks passed
@yhaliaw yhaliaw deleted the feat/app-integration branch April 29, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants