feat: Support terminated options like find -exec#2
Merged
niemeyer merged 1 commit intocanonical:masterfrom Mar 27, 2023
Merged
Conversation
Enable option to receive arguments until specified terminator
is reached or EOL has been found. This is inspired from
``find -exec [commands..] ;`` where commands.. is treated as
arguments to -exec.
If for an option ``opt``, ``terminator`` is specified to be
; (semi-colon), in the following
$ program [options] --opt v --w=x -- "y z" \; [more-options]
--opt will receive {"v", "--w=x", "--", "y z"} as its
argument. Note that, the -- inside will also be passed to
--opt regardless PassDoubleDash is set or not. However,
once the scope of --opt is finished, i.e. terminator ;
is reached, -- will act as before if PassDoubleDash is set.
Use tag ``terminator`` to specify the terminator for
the option related to that field.
Please note that, the specified terminator should be a
separate token, instead of being jotted with other characters.
For example,
--opt [arguments..] ; [options..]
will be correctly parsed with terminator: ";". However,
--opt [arguments..] arg; [options..]
will not be correctly parsed. The parser will pass "arg;",
and continue to look for the terminator in [options..].
Author
|
Upstream PR with the same change, for reference: jessevdk#395 |
benhoyt
approved these changes
Mar 13, 2023
benhoyt
left a comment
benhoyt
left a comment
There was a problem hiding this comment.
I've already reviewed this fairly thoroughly over on the upstream PR, and @rebornplusplus has already updated it with that feedback, so no further comments here. Looks good to me!
niemeyer
approved these changes
Mar 27, 2023
| // | ||
| // As shown, "--" between the option and the terminator won't trigger | ||
| // double-dash handling (if PassDoubleDash is set), but after the | ||
| // terminator it will. |
There was a problem hiding this comment.
Nice behavior, and nice explanation. Thanks.
| if len(value) > 0 { | ||
| elemVal = reflect.Indirect(reflect.New(elemTp)) | ||
| for _, val := range value { | ||
| if err := convert(val, elemVal, option.tag); err != nil { |
There was a problem hiding this comment.
That's quite a confusing API. It's not just converting, but appending the item. Anyway, not something we need to do something about right now.
rebornplusplus
pushed a commit
to rebornplusplus/pebble
that referenced
this pull request
Mar 30, 2023
canonical/go-flags#2 has been merged. Point to the recent commit canonical/go-flags@01157a7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable option to receive arguments until specified terminator is reached or EOL has been found. This is inspired from
find -exec [commands..] ;where commands.. is treated as arguments to -exec.If for an option
opt,terminatoris specified to be ; (semi-colon), in the following--opt will receive {"v", "--w=x", "--", "y z"} as its argument. Note that, the -- inside will also be passed to --opt regardless PassDoubleDash is set or not. However, once the scope of --opt is finished, i.e. terminator ; is reached, -- will act as before if PassDoubleDash is set.
Use tag
terminatorto specify the terminator for the option related to that field.Please note that, the specified terminator should be a separate token, instead of being jotted with other characters. For example,
will be correctly parsed with terminator: ";". However,
will not be correctly parsed. The parser will pass "arg;", and continue to look for the terminator in [options..].