Skip to content

ci: arm64 support #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2024
Merged

ci: arm64 support #312

merged 2 commits into from
Sep 20, 2024

Conversation

@jneo8
Copy link
Contributor

@jneo8 jneo8 commented Sep 13, 2024 •
edited
Loading

@jneo8 jneo8 requested a review from a team as a code owner September 13, 2024 03:52
@jneo8 jneo8 force-pushed the ci/arm64-runner branch 14 times, most recently from b385487 to 401f0c9 Compare September 16, 2024 04:30
@jneo8
Copy link
Contributor Author

jneo8 commented Sep 16, 2024 •
edited
Loading

I can't make grafana-agent works on arm64 machine, issue open

Couple issues:

  • I have constraints: arch=arm64 on the ubuntu application and machine on the bundle yaml file. But the revision deployed is wrong, I want 219 but 216 is deployed. (Not sure if it's a bug on pytest-operator or juju, the constraints don't help to choose the right revision).
  • After I pin the revision to 219, the error message still the same.

@jneo8 jneo8 force-pushed the ci/arm64-runner branch 7 times, most recently from 7b84e47 to bb879b2 Compare September 20, 2024 06:37
chanchiwai-ray
chanchiwai-ray reviewed Sep 20, 2024
View reviewed changes
samuelallan72
samuelallan72 suggested changes Sep 20, 2024
View reviewed changes
Copy link

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the constraints for grafana-agent across architectures in the bundle is still being worked on, but I left some comments on other areas in the PR. Thanks :)

@jneo8 jneo8 force-pushed the ci/arm64-runner branch 2 times, most recently from 83afed3 to de0c2d7 Compare September 20, 2024 07:39
chanchiwai-ray
chanchiwai-ray reviewed Sep 20, 2024
View reviewed changes
@jneo8
ci: POC arm64 runner
86c2e4f 
- Fix issue #314, missing testing model on crashdump
- Add arm64 functional test
- Add arm64 charm build
chanchiwai-ray
chanchiwai-ray previously approved these changes Sep 20, 2024
View reviewed changes
@jneo8 jneo8 changed the title [WIP] ci: POC arm64 runner ci: arm64 support Sep 20, 2024
samuelallan72
samuelallan72 suggested changes Sep 20, 2024
View reviewed changes
samuelallan72
samuelallan72 approved these changes Sep 20, 2024
View reviewed changes
Copy link

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me :D

@jneo8 jneo8 merged commit 1396dbd into main Sep 20, 2024
9 checks passed
@samuelallan72 samuelallan72 deleted the ci/arm64-runner branch September 20, 2024 09:03
@Pjack Pjack mentioned this pull request Dec 16, 2024
Closed
@samuelallan72 samuelallan72 mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

+1 more reviewer

@samuelallan72 samuelallan72 samuelallan72 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jneo8 @samuelallan72 @chanchiwai-ray